-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[RISCV][VLOPT] Add support for checkUsers when UserMI is a Single-Width Integer Reduction #120345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
3b0709e
[RISCV][VLOPT] Add support for checkUsers when UserMI is an reduction
michaelmaitland 3acf8c4
fixup! add more incompat tests
michaelmaitland 27de222
fixup! do not else after continue/break
michaelmaitland dac7acf
fixup! rerun test checks
michaelmaitland 3fc5297
fixup! move continue
michaelmaitland fcf4d81
fixup! VL operand is never x0
michaelmaitland 6a27058
fixup! fix typo
michaelmaitland f8ce58c
fixup! be less conservative
michaelmaitland f4dc6b3
fixup! fix tests after rebase:
michaelmaitland 68cd004
fixup! add test case where reduction has VL=0
michaelmaitland ab12f92
fixup! add instructions to isVectorOpUsedAsScalarOp
michaelmaitland 4656b45
fixup! fix operand number and add special case when no vlop
michaelmaitland 4e463d7
fixup! update test
michaelmaitland b8c3411
fixup! improve how we assign CommonVL
michaelmaitland e6f2468
fixup! refactor to address preames comments
michaelmaitland 5232e6f
fixup! fix comment
michaelmaitland 8d50a38
fixup! fix typo
michaelmaitland 61e681c
fixup! respond to review
michaelmaitland 595a709
fixup! move VLOp check
michaelmaitland fe55f64
fixup! update tests
michaelmaitland 4666a7f
fixup! respond to review
michaelmaitland f8c54d4
fixup! simplify getMinimumVLForUser
michaelmaitland 85f49a5
fixup! update comment
michaelmaitland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a possible follow up - in general, I think a larger source LMUL is fine. You could unify the code here by returning the smallest legal LMUL for the given SEW for the scalar source operand, and then using a greater than comparison for EMUL here. Not sure if that improves readability or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another way of phrasing this could be "is vlmax known greater than or equal to"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy to address this in a follow up patch.