AMDGPU: Fix mishandling of search for constantexpr addrspacecasts #120346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was assuming that the top level constant expression was an addrspacecast. The first encountered expression may not be pointer typed, and may not be the addrspacecast. We need to distinguish the types of addrspacecasts unlike the previous queue ptr search, so do that. Fixes #120256
jwanggit86
reviewed
Dec 18, 2024
| @@ -234,12 +241,18 @@ class AMDGPUInformationCache : public InformationCache { | |||
|
|
|||
| private: | |||
| /// Check if the ConstantExpr \p CE requires the queue pointer. | |||
There was a problem hiding this comment.
This comment on what the function does needs to be updated.
arsenm
deleted the
users/arsenm/issue120256/fix-handling-of-constexpr-addrspacecasts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was assuming that the top level constant expression was an
addrspacecast. The first encountered expression may not be pointer typed,
and may not be the addrspacecast. We need to distinguish the types of
addrspacecasts unlike the previous queue ptr search, so do that.
Fixes #120256