Skip to content

llvm-cov: Introduce -show-created-time to suppress timestamps #120417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

chapuni
Copy link
Contributor

@chapuni chapuni commented Dec 18, 2024

This shouldn't affect anything since -show-created-time=true by default.

Timestamps sometimes prevent reproducible build.

NFC since `-show-created-time=true` by default.
Copy link

@ornata ornata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wouldn't call this NFC since the change does add new functionality.

@yhgu2000
Copy link
Contributor

LGTM. Let's merge them?

@chapuni
Copy link
Contributor Author

chapuni commented Dec 19, 2024

@ornata I've updated the description body.

@chapuni chapuni merged commit 4e3c0bb into main Dec 20, 2024
10 checks passed
@chapuni chapuni deleted the users/chapuni/cov/created branch December 20, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants