Skip to content

[llvm-exegesis] Fix warnings #120451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kazutakahirata
Copy link
Contributor

This patch fixes:

lib/Target/RISCV/RISCVGenAsmMatcher.inc:239:19: error: unused
function 'MatchRegisterName' [-Werror,-Wunused-function]

lib/Target/RISCV/RISCVGenAsmMatcher.inc:568:19: error: unused
function 'MatchRegisterAltName' [-Werror,-Wunused-function]

This patch fixes:

  lib/Target/RISCV/RISCVGenAsmMatcher.inc:239:19: error: unused
  function 'MatchRegisterName' [-Werror,-Wunused-function]

  lib/Target/RISCV/RISCVGenAsmMatcher.inc:568:19: error: unused
  function 'MatchRegisterAltName' [-Werror,-Wunused-function]
@llvmbot
Copy link
Member

llvmbot commented Dec 18, 2024

@llvm/pr-subscribers-tools-llvm-exegesis

Author: Kazu Hirata (kazutakahirata)

Changes

This patch fixes:

lib/Target/RISCV/RISCVGenAsmMatcher.inc:239:19: error: unused
function 'MatchRegisterName' [-Werror,-Wunused-function]

lib/Target/RISCV/RISCVGenAsmMatcher.inc:568:19: error: unused
function 'MatchRegisterAltName' [-Werror,-Wunused-function]


Full diff: https://github.com/llvm/llvm-project/pull/120451.diff

1 Files Affected:

  • (modified) llvm/tools/llvm-exegesis/lib/RISCV/Target.cpp (-3)
diff --git a/llvm/tools/llvm-exegesis/lib/RISCV/Target.cpp b/llvm/tools/llvm-exegesis/lib/RISCV/Target.cpp
index 891818b625fe14..41d361532908ca 100644
--- a/llvm/tools/llvm-exegesis/lib/RISCV/Target.cpp
+++ b/llvm/tools/llvm-exegesis/lib/RISCV/Target.cpp
@@ -135,9 +135,6 @@ ExegesisRISCVTarget::ExegesisRISCVTarget()
     : ExegesisTarget(ArrayRef<CpuAndPfmCounters>{},
                      RISCV_MC::isOpcodeAvailable) {}
 
-#define GET_REGISTER_MATCHER
-#include "RISCVGenAsmMatcher.inc"
-
 bool ExegesisRISCVTarget::matchesArch(Triple::ArchType Arch) const {
   return Arch == Triple::riscv32 || Arch == Triple::riscv64;
 }

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@kazutakahirata
Copy link
Contributor Author

This will be part of the reland #120467. Closing.

@kazutakahirata kazutakahirata deleted the cleanup_001_warnings_llvm_exegesis branch January 22, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants