Skip to content

[TableGen] Avoid repeated hash lookups (NFC) #120532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[TableGen] Avoid repeated hash lookups (NFC) #120532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3007,13 +3007,12 @@ TreePatternNodePtr TreePattern::ParseTreePattern(const Init *TheInit,
// and "(MY_PAT $b, $a)" should not be allowed in the same pattern;
// neither should "(MY_PAT_1 $a, $b)" and "(MY_PAT_2 $a, $b)".
auto OperandId = std::make_pair(Operator, i);
auto PrevOp = ComplexPatternOperands.find(Child->getName());
if (PrevOp != ComplexPatternOperands.end()) {
if (PrevOp->getValue() != OperandId)
error("All ComplexPattern operands must appear consistently: "
"in the same order in just one ComplexPattern instance.");
} else
ComplexPatternOperands[Child->getName()] = OperandId;
auto [PrevOp, Inserted] =
ComplexPatternOperands.try_emplace(Child->getName(), OperandId);
if (!Inserted && PrevOp->getValue() != OperandId) {
error("All ComplexPattern operands must appear consistently: "
"in the same order in just one ComplexPattern instance.");
}
}
}

Expand Down Expand Up @@ -3095,14 +3094,14 @@ bool TreePattern::InferAllTypes(
// If we have input named node types, propagate their types to the named
// values here.
if (InNamedTypes) {
if (!InNamedTypes->count(Entry.getKey())) {
auto InIter = InNamedTypes->find(Entry.getKey());
if (InIter == InNamedTypes->end()) {
error("Node '" + std::string(Entry.getKey()) +
"' in output pattern but not input pattern");
return true;
}

const SmallVectorImpl<TreePatternNode *> &InNodes =
InNamedTypes->find(Entry.getKey())->second;
const SmallVectorImpl<TreePatternNode *> &InNodes = InIter->second;

// The input types should be fully resolved by now.
for (TreePatternNode *Node : Nodes) {
Expand Down Expand Up @@ -3855,7 +3854,8 @@ void CodeGenDAGPatterns::parseInstructionPattern(CodeGenInstruction &CGI,
continue;
}

if (!InstInputs.count(OpName)) {
auto InIter = InstInputs.find(OpName);
if (InIter == InstInputs.end()) {
// If this is an operand with a DefaultOps set filled in, we can ignore
// this. When we codegen it, we will do so as always executed.
if (Op.Rec->isSubClassOf("OperandWithDefaultOps")) {
Expand All @@ -3868,8 +3868,8 @@ void CodeGenDAGPatterns::parseInstructionPattern(CodeGenInstruction &CGI,
" does not appear in the instruction pattern");
continue;
}
TreePatternNodePtr InVal = InstInputs[OpName];
InstInputs.erase(OpName); // It occurred, remove from map.
TreePatternNodePtr InVal = InIter->second;
InstInputs.erase(InIter); // It occurred, remove from map.

if (InVal->isLeaf() && isa<DefInit>(InVal->getLeafValue())) {
const Record *InRec = cast<DefInit>(InVal->getLeafValue())->getDef();
Expand Down
Loading