[docs] Mention ffmpeg and dav1d in llvm-test-suite #120570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm/docs/TestSuiteGuide.md
Outdated
| @@ -367,6 +367,18 @@ For the SPEC benchmarks you can switch between the `test`, `train` and | |||
| `ref` input datasets via the `TEST_SUITE_RUN_TYPE` configuration option. | |||
| The `train` dataset is used by default. | |||
|
|
|||
| In addition to SPEC, the multimedia frameworks ffmpeg and dav1d can also | |||
| be hooked up as external projects in the same way. Adding them doesn't | |||
| add the respective projects' full testsuites though. But by including | |||
There was a problem hiding this comment.
One nit, one possible clarification about the "doesn't add the full test suites though". I think this may leave a reader wondering what is added instead. I think you explain that further down with:
There is a small code correctness test that compares
the output of the compiler generated functions against handwritten assembly
versions.
So perhaps if you move this up, you can then relate or contrast this to the "doesn't add the full test suite" in previous sentence.
There was a problem hiding this comment.
Good points, thanks. Yes, it reads much better if we start out by telling you what you get from it, rather than telling you what you don't; I rewrote it in such an order now.
Since llvm/llvm-test-suite#182 and llvm/llvm-test-suite#188, these projects can now be added as external projects within llvm-test-suite.
mstorsjo
force-pushed
the
test-suite-ffmpeg-dav1d
branch
from
e1500bf to
6a159a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since llvm/llvm-test-suite#182 and llvm/llvm-test-suite#188, these projects can now be added as external projects within llvm-test-suite.