[libc++] Fix erroneous internal capacity evaluation in vector<bool> #120577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Peng Liu (winner245) ChangesFull diff: https://github.com/llvm/llvm-project/pull/120577.diff 1 Files Affected:
diff --git a/libcxx/include/__vector/vector_bool.h b/libcxx/include/__vector/vector_bool.h
index 36eb7f350ac406..2409626ad20d9c 100644
--- a/libcxx/include/__vector/vector_bool.h
+++ b/libcxx/include/__vector/vector_bool.h
@@ -115,7 +115,7 @@ class _LIBCPP_TEMPLATE_VIS vector<bool, _Allocator> {
}
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 static size_type
__external_cap_to_internal(size_type __n) _NOEXCEPT {
- return (__n - 1) / __bits_per_word + 1;
+ return (__n + __bits_per_word - 1) / __bits_per_word;
}
public:
|
winner245
force-pushed
the
fix-underflow
branch
from
7a689f9 to
1218243
Compare
winner245
force-pushed
the
fix-underflow
branch
from
1218243 to
e1b3a68
Compare
winner245
changed the title
winner245
changed the title
winner245
force-pushed
the
fix-underflow
branch
from
e1b3a68 to
756e7a2
Compare
ldionne
approved these changes
Jan 7, 2025
frederick-vs-ja
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the erroneous internal capacity evaluation in
vector<bool>, which caused a subsequent SIGSEGV error when callingflip()onvector<bool>. By fixing the internal capacity evaluation, the SIGSEGV is automatically resolved.Closes #121726.