Skip to content

[LLVM] Update inlining maintainers #120579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2025
Merged

[LLVM] Update inlining maintainers #120579

merged 3 commits into from
Jan 8, 2025

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Dec 19, 2024

See developer policy for context on the maintainers terminology.

We currently list @chandlerc as the maintainer for inlining, but I don't think he works on that area nowadays.

I'd like to nominate @aeubanks and @mtrofin as new maintainers for inlining. I'm also adding @aeubanks as the maintainer for NewPM/CGCSS/LazyCallGraph, which are quite closely intertwined with inlining.

@nikic
Copy link
Contributor Author

nikic commented Dec 19, 2024

@chandlerc On a semi-related note, you are also listed as the maintainer of SROA/Mem2Reg. I don't really have a replacement for that area, so I can either just leave you listed there, or drop that category entirely...

@mtrofin
Copy link
Member

mtrofin commented Dec 19, 2024

I'd suggest adding @kazutakahirata as well.

lgtm for me.

Copy link
Member

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chandlerc On a semi-related note, you are also listed as the maintainer of SROA/Mem2Reg. I don't really have a replacement for that area, so I can either just leave you listed there, or drop that category entirely...

From recent changes, you or @aeubanks might be OK?

Going back further, both @LebedevRI and @arsenm have made substantial changes to SROA.

It's still near and dear to my heart, but definitely good to have a more current and active maintainer. =D

@nikic nikic force-pushed the inlining-maintainer branch 2 times, most recently from 726ed10 to 5e1832e Compare December 20, 2024 08:53
@nikic
Copy link
Contributor Author

nikic commented Dec 20, 2024

I'd suggest adding @kazutakahirata as well.

Done. I've added "module inliner and inline order" as the focus area -- does that sound correct?

@nikic
Copy link
Contributor Author

nikic commented Jan 6, 2025

Ping @kazutakahirata, to confirm whether you want to be listed as a maintainer for inlining.

@kazutakahirata
Copy link
Contributor

Ping @kazutakahirata, to confirm whether you want to be listed as a maintainer for inlining.

Yes, thanks!

@nikic nikic force-pushed the inlining-maintainer branch from 5e1832e to 9f66c3a Compare January 8, 2025 08:49
@nikic nikic merged commit e534178 into llvm:main Jan 8, 2025
5 of 7 checks passed
@nikic nikic deleted the inlining-maintainer branch January 8, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants