[clang][dataflow] Fix a missing break from a switch case -Wimplicit-fallthrough #120739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
llvmbot
added
clang
|
@llvm/pr-subscribers-clang-analysis Author: Jan Voung (jvoung) ChangesMissed when changing code in #120102 Full diff: https://github.com/llvm/llvm-project/pull/120739.diff 1 Files Affected:
diff --git a/clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp b/clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp
index 546f128531df3c..a0c81aa933da8e 100644
--- a/clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp
+++ b/clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp
@@ -71,7 +71,7 @@ bool hasSmartPointerClassShape(const CXXRecordDecl &RD, bool &HasGet,
->getCanonicalTypeUnqualified();
}
}
- }
+ } break;
default:
break;
}
|
|
@llvm/pr-subscribers-clang Author: Jan Voung (jvoung) ChangesMissed when changing code in #120102 Full diff: https://github.com/llvm/llvm-project/pull/120739.diff 1 Files Affected:
diff --git a/clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp b/clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp
index 546f128531df3c..a0c81aa933da8e 100644
--- a/clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp
+++ b/clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp
@@ -71,7 +71,7 @@ bool hasSmartPointerClassShape(const CXXRecordDecl &RD, bool &HasGet,
->getCanonicalTypeUnqualified();
}
}
- }
+ } break;
default:
break;
}
|
ymand
reviewed
Dec 20, 2024
ymand
approved these changes
Dec 20, 2024
DavidSpickett
changed the title
|
Thanks for the fix! |
Thanks for helping merge! And sorry again about the breakage! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed when changing code in #120102