[lldb] Negate is_signed variable for argument isUnsigned in TypeSystemClang.cpp

[kuilpd]

No description provided.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Ilia Kuklin (kuilpd)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/120794.diff

1 Files Affected:

• (modified) lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp (+1-1)

diff --git a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
index 3ec25a2e8aa2df..06c04c992efc09 100644
--- a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
+++ b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
@@ -8534,7 +8534,7 @@ clang::EnumConstantDecl *TypeSystemClang::AddEnumerationValueToEnumerationType(
   bool is_signed = false;
   underlying_type.IsIntegerType(is_signed);
 
-  llvm::APSInt value(enum_value_bit_size, is_signed);
+  llvm::APSInt value(enum_value_bit_size, !is_signed);
   value = enum_value;
 
   return AddEnumerationValueToEnumerationType(enum_type, decl, name, value);

[kuilpd]

This change doesn't really affect anything in lldb yet, but will be used and tested afterwards in #115005

[Michael137]

LGTM

Can we add a test for this in lldb/unittests/Symbol/TestTypeSystemClang.cpp? We could call this API and then use EnumConstantDecl::getInitVal to retrieve the APSInt and make sure it's unsigned

[Michael137]

Nit:

Suggested change

	auto *enum_decl = m_ast->AddEnumerationValueToEnumerationType(
	enum_type, nullptr, "minus_one", -1, 8);
	auto *enum_decl = m_ast->AddEnumerationValueToEnumerationType(
	enum_type, Declaration(), "minus_one", -1, 8);

[Michael137]

LGTM, thanks! (one minor nit in the test)