Reapply "[llvm-jitlink] Use concurrent linking by default." with fixes. #120958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reapplies commit edca1d9 which was reverted in 34531cf while I investigated bot failures, (e.g. https://lab.llvm.org/buildbot/#/builders/137/builds/10791). Commit 158a600 should address the -check failures on the bots, which were caused by checks running earlier under the concurrent linking scheme, before all files referenced by the checks had been fully linked. This patch also fixes the -threads option failure by renaming the option to -num-threads to avoid clashing with the ThreadCount cl::opt variable defined in ThinLTOCodeGenerator.cpp.
lhames
force-pushed
the
jitlink-enable-concurrency
branch
from
8bdbcda to
38eb730
Compare
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/108/builds/7490 Here is the relevant piece of the build log for the reference |
|
@lhames Looks like this triggered occasional failures, possibly due to interrupted messages by insufficient locks. https://lab.llvm.org/buildbot/#/builders/174/builds/10572 |
|
Thanks for the revert @chapuni! I'll take a look when I get back to my desk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapplies commit edca1d9 which was reverted in 34531cf while I investigated bot failures, (e.g.
https://lab.llvm.org/buildbot/#/builders/137/builds/10791).
Commit 158a600 should address the -check failures on the bots, which were caused by checks running earlier under the concurrent linking scheme, before all files referenced by the checks had been fully linked. This patch also fixes the -threads option failure by renaming the option to -num-threads to avoid clashing with the ThreadCount cl::opt variable defined in ThinLTOCodeGenerator.cpp.