Skip to content

[mlir][IntRangeInference] Fix arith.ceildivsi range inference when it includes INT_MIN #121062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2024
Merged

[mlir][IntRangeInference] Fix arith.ceildivsi range inference when it includes INT_MIN #121062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion mlir/lib/Interfaces/Utils/InferIntRangeCommon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,15 @@ mlir::intrange::inferCeilDivS(ArrayRef<ConstantIntRanges> argRanges) {
}
return result;
};
return inferDivSRange(lhs, rhs, ceilDivSIFix);
ConstantIntRanges result = inferDivSRange(lhs, rhs, ceilDivSIFix);
if (lhs.smin().isMinSignedValue() && lhs.smax().sgt(lhs.smin())) {
// If lhs range includes INT_MIN and lhs is not a single value, we can
// suddenly wrap to positive val, skipping entire negative range, add
// [INT_MIN + 1, smax()] range to the result to handle this.
auto newLhs = ConstantIntRanges::fromSigned(lhs.smin() + 1, lhs.smax());
result = result.rangeUnion(inferDivSRange(newLhs, rhs, ceilDivSIFix));
}
return result;
}

ConstantIntRanges
Expand Down
12 changes: 12 additions & 0 deletions mlir/test/Dialect/Arith/int-range-interface.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,18 @@ func.func @ceil_divsi(%arg0 : index) -> i1 {
func.return %10 : i1
}

// There was a bug, which was causing this expr errorneously fold to constant
// CHECK-LABEL: func @ceil_divsi_full_range
// CHECK-SAME: (%[[arg:.*]]: index)
// CHECK: %[[c64:.*]] = arith.constant 64 : index
// CHECK: %[[ret:.*]] = arith.ceildivsi %[[arg]], %[[c64]] : index
// CHECK: return %[[ret]]
func.func @ceil_divsi_full_range(%6: index) -> index {
%c64 = arith.constant 64 : index
%55 = arith.ceildivsi %6, %c64 : index
return %55 : index
}

// CHECK-LABEL: func @ceil_divsi_intmin_bug_115293
// CHECK: %[[ret:.*]] = arith.constant true
// CHECK: return %[[ret]]
Expand Down
Loading