Skip to content

[mlir][emitc] Fix invalid syntax in example of emitc.return #121112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

hatoo
Copy link
Contributor

@hatoo hatoo commented Dec 25, 2024

A return type of emitc.func must be specified with -> instead of :.
I've verified the syntax using mlir-translate --mlir-to-cpp.

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot
Copy link
Member

llvmbot commented Dec 25, 2024

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-emitc

Author: None (hatoo)

Changes

A return type of emitc.func must be specified with -> instead of :.
I've verified the syntax using mlir-translate --mlir-to-cpp.


Full diff: https://github.com/llvm/llvm-project/pull/121112.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Dialect/EmitC/IR/EmitC.td (+1-1)
diff --git a/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td b/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
index fc5a33541533a7..74c5218df58a28 100644
--- a/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
+++ b/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td
@@ -727,7 +727,7 @@ def EmitC_ReturnOp : EmitC_Op<"return", [Pure, HasParent<"FuncOp">,
     Example:
 
     ```mlir
-    emitc.func @foo() : (i32) {
+    emitc.func @foo() -> (i32) {
       ...
       emitc.return %0 : i32
     }

Copy link
Member

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@marbre
Copy link
Member

marbre commented Jan 2, 2025

Let me know if I should merge on your behalf.

marbre added a commit that referenced this pull request Jan 2, 2025
@hatoo
Copy link
Contributor Author

hatoo commented Jan 2, 2025

Let me know if I should merge on your behalf.

image

I don't have permission to merge.
Could you please merge this instead of me?

@marbre marbre merged commit cbff02b into llvm:main Jan 2, 2025
9 checks passed
Copy link

github-actions bot commented Jan 2, 2025

@hatoo Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@marbre
Copy link
Member

marbre commented Jan 2, 2025

I don't have permission to merge. Could you please merge this instead of me?

Sure! Thanks again for the fix.

@hatoo hatoo deleted the fix-emitc.return-example branch January 3, 2025 01:54
qiaojbao pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Feb 7, 2025
Local branch amd-gfx fd35e8e Merged main:11e482c4a32b into amd-gfx:176390732d3e
Remote branch main cbff02b [mlir][emitc] Fix invalid syntax in example of emitc.return (llvm#121112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants