[mlir] minor documentation fix in GPUTransformOps.td #121157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not refer to handles as `PDLOperation`, this is an outdated and incorrect vision of what they are based on the type used in the early days; - use backticks around inline code.
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-gpu Author: Oleksandr "Alex" Zinenko (ftynse) Changes
Full diff: https://github.com/llvm/llvm-project/pull/121157.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/GPU/TransformOps/GPUTransformOps.td b/mlir/include/mlir/Dialect/GPU/TransformOps/GPUTransformOps.td
index 80b4547c32c101..61d4ccec5f0bd5 100644
--- a/mlir/include/mlir/Dialect/GPU/TransformOps/GPUTransformOps.td
+++ b/mlir/include/mlir/Dialect/GPU/TransformOps/GPUTransformOps.td
@@ -168,13 +168,13 @@ def MapNestedForallToThreads :
#### Return modes:
- This operation ignores non-gpu_launch ops and drops them in the return.
+ This operation ignores non-`gpu_launch` ops and drops them in the return.
If any scf.forall with tensors is found, the transform definitely
fails.
- If all the scf.forall operations with gpu.thread mapping contained
- within the LaunchOp referred to by the `target` PDLOperation lower to GPU
+ If all the `scf.forall` operations with gpu.thread mapping contained
+ within the `LaunchOp` referred to by the `target` handle lower to GPU
properly, the transform succeeds. Otherwise the transform definitely
fails.
@@ -277,8 +277,8 @@ def MapForallToBlocks :
If any scf.forall with tensors is found, the transform definitely
fails.
- If all the scf.forall operations contained within the LaunchOp
- referred to by the `target` PDLOperation lower to GPU properly, the
+ If all the `scf.forall` operations contained within the LaunchOp
+ referred to by the `target` handle lower to GPU properly, the
transform succeeds. Otherwise the transform definitely fails.
The returned handle points to the same LaunchOp operand, consuming it and
|
|
Trivial documentation change, merging. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/52/builds/4798 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDLOperation, this is an outdated and incorrect vision of what they are based on the type used in the early days;