Skip to content

[LoongArch] Add relax relocations for tls_le code sequence #121329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2025
Merged

[LoongArch] Add relax relocations for tls_le code sequence #121329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ee3b7a
[LoongArch] Add relax relocations for tls_le code sequence
zhaoqi5 Dec 30, 2024
b14954e
address comment
zhaoqi5 Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchMCCodeEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,9 +282,11 @@ LoongArchMCCodeEmitter::getExprOpValue(const MCInst &MI, const MCOperand &MO,
break;
case LoongArchMCExpr::VK_LoongArch_TLS_LE_HI20_R:
FixupKind = LoongArch::fixup_loongarch_tls_le_hi20_r;
RelaxCandidate = true;
break;
case LoongArchMCExpr::VK_LoongArch_TLS_LE_LO12_R:
FixupKind = LoongArch::fixup_loongarch_tls_le_lo12_r;
RelaxCandidate = true;
break;
case LoongArchMCExpr::VK_LoongArch_PCREL20_S2:
FixupKind = LoongArch::fixup_loongarch_pcrel20_s2;
Expand Down Expand Up @@ -387,11 +389,17 @@ void LoongArchMCCodeEmitter::expandAddTPRel(const MCInst &MI,
"Expected %le_add_r relocation on TP-relative symbol");

// Emit the correct %le_add_r relocation for the symbol.
// TODO: Emit R_LARCH_RELAX for %le_add_r where the relax feature is enabled.
Fixups.push_back(MCFixup::create(
0, Expr, MCFixupKind(LoongArch::fixup_loongarch_tls_le_add_r),
MI.getLoc()));

// Emit R_LARCH_RELAX for %le_add_r when the relax feature is enabled.
if (STI.hasFeature(LoongArch::FeatureRelax)) {
const MCConstantExpr *Dummy = MCConstantExpr::create(0, Ctx);
Fixups.push_back(MCFixup::create(
0, Dummy, MCFixupKind(LoongArch::fixup_loongarch_relax), MI.getLoc()));
}

// Emit a normal ADD instruction with the given operands.
unsigned ADD = MI.getOpcode() == LoongArch::PseudoAddTPRel_D
? LoongArch::ADD_D
Expand Down
70 changes: 70 additions & 0 deletions llvm/test/MC/LoongArch/Relocations/relax-tls-le.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
# RUN: llvm-mc --filetype=obj --triple=loongarch32 --mattr=+relax < %s \
# RUN: | llvm-readobj -r - | FileCheck --check-prefix=LA32-RELAX-RELOC %s
# RUN: llvm-mc --filetype=obj --triple=loongarch32 --mattr=-relax < %s \
# RUN: | llvm-readobj -r - | FileCheck --check-prefix=LA32-NORELAX-RELOC %s
# RUN: llvm-mc --triple=loongarch32 --mattr=+relax < %s --show-encoding \
# RUN: | FileCheck --check-prefix=LA32-RELAX-FIXUP %s

# RUN: llvm-mc --filetype=obj --triple=loongarch64 --mattr=+relax --defsym=LA64=1 < %s \
# RUN: | llvm-readobj -r - | FileCheck --check-prefix=LA64-RELAX-RELOC %s
# RUN: llvm-mc --filetype=obj --triple=loongarch64 --mattr=-relax --defsym=LA64=1 < %s \
# RUN: | llvm-readobj -r - | FileCheck --check-prefix=LA64-NORELAX-RELOC %s
# RUN: llvm-mc --triple=loongarch64 --mattr=+relax --defsym=LA64=1 < %s --show-encoding \
# RUN: | FileCheck --check-prefix=LA64-RELAX-FIXUP %s

.long foo

.ifndef LA64

lu12i.w $a0, %le_hi20_r(foo)
# LA32-NORELAX-RELOC: R_LARCH_TLS_LE_HI20_R foo 0x0
# LA32-NORELAX-RELOC-NOT: R_LARCH_RELAX - 0x0
# LA32-RELAX-RELOC: R_LARCH_TLS_LE_HI20_R foo 0x0
# LA32-RELAX-RELOC: R_LARCH_RELAX - 0x0
# LA32-RELAX-FIXUP: fixup A - offset: 0, value: %le_hi20_r(foo), kind: FK_NONE
# LA32-RELAX-FIXUP: fixup B - offset: 0, value: 0, kind: FK_NONE

add.w $a0, $a0, $tp, %le_add_r(foo)
# LA32-NORELAX-RELOC: R_LARCH_TLS_LE_ADD_R foo 0x0
# LA32-NORELAX-RELOC-NOT: R_LARCH_RELAX - 0x0
# LA32-RELAX-RELOC: R_LARCH_TLS_LE_ADD_R foo 0x0
# LA32-RELAX-RELOC: R_LARCH_RELAX - 0x0
# LA32-RELAX-FIXUP: fixup A - offset: 0, value: %le_add_r(foo), kind: FK_NONE
# LA32-RELAX-FIXUP: fixup B - offset: 0, value: 0, kind: FK_NONE

addi.w $a0, $a0, %le_lo12_r(foo)
# LA32-NORELAX-RELOC: R_LARCH_TLS_LE_LO12_R foo 0x0
# LA32-NORELAX-RELOC-NOT: R_LARCH_RELAX - 0x0
# LA32-RELAX-RELOC: R_LARCH_TLS_LE_LO12_R foo 0x0
# LA32-RELAX-RELOC: R_LARCH_RELAX - 0x0
# LA32-RELAX-FIXUP: fixup A - offset: 0, value: %le_lo12_r(foo), kind: FK_NONE
# LA32-RELAX-FIXUP: fixup B - offset: 0, value: 0, kind: FK_NONE

.else

lu12i.w $a0, %le_hi20_r(foo)
# LA64-NORELAX-RELOC: R_LARCH_TLS_LE_HI20_R foo 0x0
# LA64-NORELAX-RELOC-NOT: R_LARCH_RELAX - 0x0
# LA64-RELAX-RELOC: R_LARCH_TLS_LE_HI20_R foo 0x0
# LA64-RELAX-RELOC: R_LARCH_RELAX - 0x0
# LA64-RELAX-FIXUP: fixup A - offset: 0, value: %le_hi20_r(foo), kind: FK_NONE
# LA64-RELAX-FIXUP: fixup B - offset: 0, value: 0, kind: FK_NONE

add.d $a0, $a0, $tp, %le_add_r(foo)
# LA64-NORELAX-RELOC: R_LARCH_TLS_LE_ADD_R foo 0x0
# LA64-NORELAX-RELOC-NOT: R_LARCH_RELAX - 0x0
# LA64-RELAX-RELOC: R_LARCH_TLS_LE_ADD_R foo 0x0
# LA64-RELAX-RELOC: R_LARCH_RELAX - 0x0
# LA64-RELAX-FIXUP: fixup A - offset: 0, value: %le_add_r(foo), kind: FK_NONE
# LA64-RELAX-FIXUP: fixup B - offset: 0, value: 0, kind: FK_NONE

addi.d $a0, $a0, %le_lo12_r(foo)
# LA64-NORELAX-RELOC: R_LARCH_TLS_LE_LO12_R foo 0x0
# LA64-NORELAX-RELOC-NOT: R_LARCH_RELAX - 0x0
# LA64-RELAX-RELOC: R_LARCH_TLS_LE_LO12_R foo 0x0
# LA64-RELAX-RELOC: R_LARCH_RELAX - 0x0
# LA64-RELAX-FIXUP: fixup A - offset: 0, value: %le_lo12_r(foo), kind: FK_NONE
# LA64-RELAX-FIXUP: fixup B - offset: 0, value: 0, kind: FK_NONE

.endif

Loading