Skip to content

[mlir] Update Ch-2.md #121379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2025
Merged

[mlir] Update Ch-2.md #121379

merged 2 commits into from
Jan 6, 2025

Conversation

Vishakh2012
Copy link
Contributor

line 265 in the file llvm-project/mlir/docs/Tutorials/Toy/Ch-2.md

changed mlir::OpTraits to mlir::OpTrait

line 265 in the file llvm-project/mlir/docs/Tutorials/Toy/Ch-2.md 

changed mlir::OpTraits to mlir::OpTrait
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the mlir label Dec 31, 2024
@llvmbot
Copy link
Member

llvmbot commented Dec 31, 2024

@llvm/pr-subscribers-mlir

Author: Vishakh Prakash (Vishakh2012)

Changes

line 265 in the file llvm-project/mlir/docs/Tutorials/Toy/Ch-2.md

changed mlir::OpTraits to mlir::OpTrait


Full diff: https://github.com/llvm/llvm-project/pull/121379.diff

1 Files Affected:

  • (modified) mlir/docs/Tutorials/Toy/Ch-2.md (+1-1)
diff --git a/mlir/docs/Tutorials/Toy/Ch-2.md b/mlir/docs/Tutorials/Toy/Ch-2.md
index b807ee3a20492d..039417c9c9a19d 100644
--- a/mlir/docs/Tutorials/Toy/Ch-2.md
+++ b/mlir/docs/Tutorials/Toy/Ch-2.md
@@ -262,7 +262,7 @@ class ConstantOp : public mlir::Op<
                      mlir::OpTrait::OneResult,
                      /// We also provide a utility `getType` accessor that
                      /// returns the TensorType of the single result.
-                     mlir::OpTraits::OneTypedResult<TensorType>::Impl> {
+                     mlir::OpTrait::OneTypedResult<TensorType>::Impl> {
 
  public:
   /// Inherit the constructors from the base Op class.

Copy link

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

@Vishakh2012
Copy link
Contributor Author

my email id was private prior to submitting this PR, I have changed it now should I send in another PR.

@ftynse
Copy link
Member

ftynse commented Jan 3, 2025

Only the email that is on the commit itself matters: https://github.com/llvm/llvm-project/commit/dd9d5801683e05712989871718dff4c468584cc3.patch. Please update the commit (e.g., git commit --amend --author="..."), rebase the branch on main and force-push it.

@CoTinker CoTinker changed the title Update Ch-2.md [mlir] Update Ch-2.md Jan 6, 2025
@CoTinker CoTinker merged commit 9d0fa42 into llvm:main Jan 6, 2025
8 checks passed
Copy link

github-actions bot commented Jan 6, 2025

@Vishakh2012 Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants