[mlir][python] declare _PyClassMethod_New undefined at link time
#121597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir Author: Maksim Levental (makslevental) Changes
See iree-org/iree#19591 (comment). Full diff: https://github.com/llvm/llvm-project/pull/121597.diff 1 Files Affected:
diff --git a/mlir/cmake/modules/AddMLIRPython.cmake b/mlir/cmake/modules/AddMLIRPython.cmake
index 9d4e06c7909c81..2bcabab6f9c5e3 100644
--- a/mlir/cmake/modules/AddMLIRPython.cmake
+++ b/mlir/cmake/modules/AddMLIRPython.cmake
@@ -686,6 +686,12 @@ function(add_mlir_python_extension libname extname)
endif()
target_compile_options(${libname} PRIVATE ${eh_rtti_enable})
+ if(APPLE)
+ # NanobindAdaptors.h uses PyClassMethod_New to build `pure_subclass`es but nanobind
+ # doesn't declare this API as undefined in its linker flags. so we need to declare it as such
+ # for downstream users that do not do something like -undefined dynamic_lookup
+ set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -Wl,-U -Wl,_PyClassMethod_New")
+ endif()
# Configure the output to match python expectations.
set_target_properties(
|
makslevental
requested review from
stellaraccident,
jpienaar,
ScottTodd and
marbre
makslevental
commented
Jan 3, 2025
ScottTodd
approved these changes
Jan 3, 2025
marbre
approved these changes
Jan 3, 2025
makslevental
commented
Jan 3, 2025
marbre
approved these changes
Jan 3, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/143/builds/4553 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NanobindAdaptors.husesPyClassMethod_Newto buildpure_subclasses but nanobind doesn't declare this API as undefined in its linker flags. So we need to declare it as such for downstream users that do not do something like-undefined dynamic_lookupSee iree-org/iree#19591 (comment).