[AggressiveInstCombine] Add tests for memchr inline threshold (NFC) #121711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-llvm-transforms Author: None (natedal) Changes(This adds a test checking that, if length=2, memchr is called. This is undesirable as it would be faster to directly compare the two array elements with the target element, rather than calling the external memchr function.) Full diff: https://github.com/llvm/llvm-project/pull/121711.diff 1 Files Affected:
diff --git a/llvm/test/Transforms/AggressiveInstCombine/memchr.ll b/llvm/test/Transforms/AggressiveInstCombine/memchr.ll
index 2601b9f05a97f9..1f1938eecafe69 100644
--- a/llvm/test/Transforms/AggressiveInstCombine/memchr.ll
+++ b/llvm/test/Transforms/AggressiveInstCombine/memchr.ll
@@ -161,3 +161,17 @@ entry:
%memchr = call ptr @memchr(ptr @str_long, i32 %x, i64 8)
ret ptr %memchr
}
+
+
+define ptr @test_memchr_non_constant_length2(i32 %x, i64 %len) {
+; CHECK-LABEL: define ptr @test_memchr_non_constant_length2(
+; CHECK-SAME: i32 [[X:%.*]], i64 [[LEN:%.*]]) {
+; CHECK-NEXT: [[ENTRY:.*:]]
+; CHECK-NEXT: ; We want to check that the compiler still calls memchr:
+; CHECK-NEXT: [[MEMCHR:%.*]] = call ptr @memchr(ptr @str, i32 [[X]], i64 [[LEN]])
+; CHECK-NEXT: ret ptr [[MEMCHR]]
+;
+entry:
+ %memchr = call ptr @memchr(ptr @str, i32 %x, i64 %len)
+ ret ptr %memchr
+}
|
dtcxzyw
reviewed
Jan 6, 2025
| ; CHECK-LABEL: define ptr @test_memchr_non_constant_length2( | ||
| ; CHECK-SAME: i32 [[X:%.*]], i64 [[LEN:%.*]]) { | ||
| ; CHECK-NEXT: [[ENTRY:.*:]] | ||
| ; CHECK-NEXT: ; We want to check that the compiler still calls memchr: |
There was a problem hiding this comment.
Please move this comment before the header of this function.
Exit Code: 1
Command Output (stderr):
--
RUN: at line 2: /var/lib/buildkite-agent/builds/linux-56-59b8f5d88-w5ssp-1/llvm-project/github-pull-requests/build/bin/opt -S -passes=aggressive-instcombine --memchr-inline-threshold=5 < /var/lib/buildkite-agent/builds/linux-56-59b8f5d88-w5ssp-1/llvm-project/github-pull-requests/llvm/test/Transforms/AggressiveInstCombine/memchr.ll | /var/lib/buildkite-agent/builds/linux-56-59b8f5d88-w5ssp-1/llvm-project/github-pull-requests/build/bin/FileCheck /var/lib/buildkite-agent/builds/linux-56-59b8f5d88-w5ssp-1/llvm-project/github-pull-requests/llvm/test/Transforms/AggressiveInstCombine/memchr.ll
+ /var/lib/buildkite-agent/builds/linux-56-59b8f5d88-w5ssp-1/llvm-project/github-pull-requests/build/bin/opt -S -passes=aggressive-instcombine --memchr-inline-threshold=5
+ /var/lib/buildkite-agent/builds/linux-56-59b8f5d88-w5ssp-1/llvm-project/github-pull-requests/build/bin/FileCheck /var/lib/buildkite-agent/builds/linux-56-59b8f5d88-w5ssp-1/llvm-project/github-pull-requests/llvm/test/Transforms/AggressiveInstCombine/memchr.ll
/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-w5ssp-1/llvm-project/github-pull-requests/llvm/test/Transforms/AggressiveInstCombine/memchr.ll:170:15: error: CHECK-NEXT: expected string not found in input
; CHECK-NEXT: ; We want to check that the compiler still calls memchr:
^
<stdin>:133:7: note: scanning from here
entry:
^
<stdin>:134:8: note: possible intended match here
%memchr = call ptr @memchr(ptr @str, i32 %x, i64 %len)
^
Input file: <stdin>
Check file: /var/lib/buildkite-agent/builds/linux-56-59b8f5d88-w5ssp-1/llvm-project/github-pull-requests/llvm/test/Transforms/AggressiveInstCombine/memchr.ll
-dump-input=help explains the following input dump.
Input was:
<<<<<<
.
.
.
128: %memchr = call ptr @memchr(ptr @str_long, i32 %x, i64 8)
129: ret ptr %memchr
130: }
131:
132: define ptr @test_memchr_non_constant_length2(i32 %x, i64 %len) {
133: entry:
next:170'0 X error: no match found
134: %memchr = call ptr @memchr(ptr @str, i32 %x, i64 %len)
next:170'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next:170'1 ? possible intended match
135: ret ptr %memchr
next:170'0 ~~~~~~~~~~~~~~~~~
136: }
next:170'0 ~~
>>>>>>
--
antoniofrighetto
changed the title
|
@natedal Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/50/builds/9555 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/12637 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This adds a test checking that, if length=2, memchr is called. This is undesirable as it would be faster to directly compare the two array elements with the target element, rather than calling the external memchr function.)