Skip to content

[mlir][Transforms] Dialect conversion: Turn LLVM_DEPRECATED into comments #122073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025
Merged

[mlir][Transforms] Dialect conversion: Turn LLVM_DEPRECATED into comments #122073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions mlir/include/mlir/Dialect/SCF/Transforms/Patterns.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,7 @@ void populateSCFStructuralTypeConversionTarget(
/// applyPartialOneToNConversion.
/// FIXME: The 1:N dialect conversion is deprecated and will be removed soon.
/// 1:N support has been added to the regular dialect conversion driver.
LLVM_DEPRECATED("Use populateSCFStructuralTypeConversions() instead",
"populateSCFStructuralTypeConversions")
/// Use populateSCFStructuralTypeConversions() instead.
void populateSCFStructuralOneToNTypeConversions(
const TypeConverter &typeConverter, RewritePatternSet &patterns);

Expand Down
11 changes: 3 additions & 8 deletions mlir/include/mlir/Transforms/OneToNTypeConversion.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,7 @@ class OneToNPatternRewriter : public PatternRewriter {
/// (i.e., the converted types must be the same as the types of the new
/// values).
/// FIXME: The 1:N dialect conversion is deprecated and will be removed soon.
/// 1:N support has been added to the regular dialect conversion driver.
LLVM_DEPRECATED("Use replaceOpWithMultiple() instead",
"replaceOpWithMultiple")
/// Use replaceOpWithMultiple() instead.
void replaceOp(Operation *op, ValueRange newValues,
const OneToNTypeMapping &resultMapping);
using PatternRewriter::replaceOp;
Expand Down Expand Up @@ -260,8 +258,7 @@ class OneToNOpConversionPattern : public OneToNConversionPattern {
/// only "partial").
/// FIXME: The 1:N dialect conversion is deprecated and will be removed soon.
/// 1:N support has been added to the regular dialect conversion driver.
LLVM_DEPRECATED("Use applyPartialConversion() instead",
"applyPartialConversion")
/// Use applyPartialConversion() instead.
LogicalResult
applyPartialOneToNConversion(Operation *op, TypeConverter &typeConverter,
const FrozenRewritePatternSet &patterns);
Expand All @@ -272,9 +269,7 @@ applyPartialOneToNConversion(Operation *op, TypeConverter &typeConverter,
/// used with the 1:N dialect conversion.
/// FIXME: The 1:N dialect conversion is deprecated and will be removed soon.
/// 1:N support has been added to the regular dialect conversion driver.
LLVM_DEPRECATED(
"Use populateFunctionOpInterfaceTypeConversionPattern() instead",
"populateFunctionOpInterfaceTypeConversionPattern")
/// Use populateFunctionOpInterfaceTypeConversionPattern() instead.
void populateOneToNFunctionOpInterfaceTypeConversionPattern(
StringRef functionLikeOpName, const TypeConverter &converter,
RewritePatternSet &patterns);
Expand Down
Loading