Skip to content

[BoundsChecking][test] Reorder RUN lines #122229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vitalybuka
Copy link
Collaborator

To match output order of update_test_checks.py.

Created using spr 1.3.4
@vitalybuka vitalybuka added the skip-precommit-approval PR for CI feedback, not intended for review label Jan 9, 2025
@vitalybuka vitalybuka requested a review from thurstond January 9, 2025 07:48
@vitalybuka vitalybuka removed the skip-precommit-approval PR for CI feedback, not intended for review label Jan 9, 2025
Copy link
Contributor

@thurstond thurstond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should lines 12-13 be removed? The new lines are duplicates, not a reordering.

@vitalybuka vitalybuka merged commit 89499c6 into main Jan 9, 2025
10 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/boundscheckingtest-reorder-run-lines branch January 9, 2025 16:59
vitalybuka added a commit that referenced this pull request Jan 9, 2025
Fixing failed conflict resolution in #122229.
@vitalybuka
Copy link
Collaborator Author

Should lines 12-13 be removed? The new lines are duplicates, not a reordering.

a7cbd41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants