Skip to content

Remove unexisting targets from bolt dockerfile #122321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Jan 9, 2025

perf2bolt and llvm-boltdiff are now not separate targets but just symlinks to llvm-bolt created when you install llvm-bolt itself so when you try to build it ninja reports there are no targets for both of them

`perf2bolt` and `llvm-boltdiff` are now not separate targets but just symlinks to `llvm-bolt` created when you install `llvm-bolt` itself so when you try to build it ninja reports there are no targets for both of them
Copy link

github-actions bot commented Jan 9, 2025

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the BOLT label Jan 9, 2025
@llvmbot
Copy link
Member

llvmbot commented Jan 9, 2025

@llvm/pr-subscribers-bolt

Author: Yevhen Babiichuk (DustDFG) (dustdfg)

Changes

perf2bolt and llvm-boltdiff are now not separate targets but just symlinks to llvm-bolt created when you install llvm-bolt itself so when you try to build it ninja reports there are no targets for both of them


Full diff: https://github.com/llvm/llvm-project/pull/122321.diff

1 Files Affected:

  • (modified) bolt/utils/docker/Dockerfile (+1-2)
diff --git a/bolt/utils/docker/Dockerfile b/bolt/utils/docker/Dockerfile
index c2108f7aec53c0..c58e1a533df94b 100644
--- a/bolt/utils/docker/Dockerfile
+++ b/bolt/utils/docker/Dockerfile
@@ -23,8 +23,7 @@ RUN mkdir build && \
       -DCMAKE_EXE_LINKER_FLAGS="-Wl,--push-state -Wl,-whole-archive -ljemalloc_pic -Wl,--pop-state -lpthread -lstdc++ -lm -ldl" \
       -DCMAKE_INSTALL_PREFIX=/home/bolt/install && \
     ninja check-bolt && \
-    ninja install-llvm-bolt install-perf2bolt install-merge-fdata \
-      install-llvm-boltdiff install-bolt_rt
+    ninja install-llvm-bolt install-merge-fdata install-bolt_rt
 
 FROM ubuntu:24.04
 

@dustdfg
Copy link
Contributor Author

dustdfg commented Mar 4, 2025

Ping

@peterwaller-arm peterwaller-arm merged commit 36cd601 into llvm:main Mar 5, 2025
7 checks passed
Copy link

github-actions bot commented Mar 5, 2025

@dustdfg Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

jph-13 pushed a commit to jph-13/llvm-project that referenced this pull request Mar 21, 2025
`perf2bolt` and `llvm-boltdiff` are now not separate targets but just
symlinks to `llvm-bolt` created when you install `llvm-bolt` itself so
when you try to build it ninja reports there are no targets for both of
them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants