[Driver][FreeBSD] Remove FreeBSD/loongarch32 support #122515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Brad Smith (brad0) ChangesFreeBSD going forward will not have 32-bit arch support. Also missed a spot with removing riscv32 support. Full diff: https://github.com/llvm/llvm-project/pull/122515.diff 4 Files Affected:
diff --git a/clang/lib/Basic/Targets.cpp b/clang/lib/Basic/Targets.cpp
index be5dedbe8044e2..872f2952a1bae2 100644
--- a/clang/lib/Basic/Targets.cpp
+++ b/clang/lib/Basic/Targets.cpp
@@ -735,9 +735,6 @@ std::unique_ptr<TargetInfo> AllocateTarget(const llvm::Triple &Triple,
case llvm::Triple::Linux:
return std::make_unique<LinuxTargetInfo<LoongArch32TargetInfo>>(Triple,
Opts);
- case llvm::Triple::FreeBSD:
- return std::make_unique<FreeBSDTargetInfo<LoongArch32TargetInfo>>(Triple,
- Opts);
default:
return std::make_unique<LoongArch32TargetInfo>(Triple, Opts);
}
diff --git a/clang/lib/Basic/Targets/OSTargets.h b/clang/lib/Basic/Targets/OSTargets.h
index 53dd23c3129636..3408b008b2217c 100644
--- a/clang/lib/Basic/Targets/OSTargets.h
+++ b/clang/lib/Basic/Targets/OSTargets.h
@@ -228,11 +228,8 @@ class LLVM_LIBRARY_VISIBILITY FreeBSDTargetInfo : public OSTargetInfo<Target> {
case llvm::Triple::arm:
this->MCountName = "__mcount";
break;
- case llvm::Triple::riscv32:
- case llvm::Triple::riscv64:
- break;
- case llvm::Triple::loongarch32:
case llvm::Triple::loongarch64:
+ case llvm::Triple::riscv64:
break;
}
}
diff --git a/clang/lib/Driver/ToolChains/FreeBSD.cpp b/clang/lib/Driver/ToolChains/FreeBSD.cpp
index 88a27e3192827f..a6d859f0ebfec2 100644
--- a/clang/lib/Driver/ToolChains/FreeBSD.cpp
+++ b/clang/lib/Driver/ToolChains/FreeBSD.cpp
@@ -213,10 +213,6 @@ void freebsd::Linker::ConstructJob(Compilation &C, const JobAction &JA,
CmdArgs.push_back("-m");
CmdArgs.push_back("elf64lriscv");
break;
- case llvm::Triple::loongarch32:
- CmdArgs.push_back("-m");
- CmdArgs.push_back("elf32loongarch");
- break;
case llvm::Triple::loongarch64:
CmdArgs.push_back("-m");
CmdArgs.push_back("elf64loongarch");
diff --git a/clang/test/Driver/freebsd.c b/clang/test/Driver/freebsd.c
index a0787bab4feb8f..94db63278bfe97 100644
--- a/clang/test/Driver/freebsd.c
+++ b/clang/test/Driver/freebsd.c
@@ -79,9 +79,6 @@
//
// Check that LoongArch passes the correct linker emulation.
//
-// RUN: %clang --target=loongarch32-freebsd -### %s %s 2>&1 \
-// RUN: | FileCheck --check-prefix=CHECK-LA32-LD %s
-// CHECK-LA32-LD: ld{{.*}}" {{.*}} "-m" "elf32loongarch"
// RUN: %clang --target=loongarch64-freebsd -### %s %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-LA64-LD %s
// CHECK-LA64-LD: ld{{.*}}" {{.*}} "-m" "elf64loongarch"
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
FreeBSD going forward will not have 32-bit arch support. Also missed a spot with removing riscv32 support.
brad0
force-pushed
the
llvm_freebsd_loongarch
branch
from
e2bec3c to
b6b7ecf
Compare
SixWeining
reviewed
Jan 20, 2025
SixWeining
approved these changes
Jan 20, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/11996 Here is the relevant piece of the build log for the reference |
brooksdavis
reviewed
Jan 24, 2025
yushanwei
added a commit
to yushanwei/freebsd-src
that referenced
this pull request
Jun 15, 2025
backport from llvm20: [clang][LoongArch] Add FreeBSD targets: llvm/llvm-project#119191 [Driver][FreeBSD] Remove FreeBSD/loongarch32 support: llvm/llvm-project#122515 Co-authored-by: haowuge <[email protected]> Co-authored-by: xiaoqiang zhao <[email protected]> Signed-off-by: yu shan wei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD going forward will not have 32-bit arch support.
Also missed a spot with removing riscv32 support.