Skip to content

[clang-doc] Precommit end-to-end test for --repository option #122565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

ilovepi
Copy link
Contributor

@ilovepi ilovepi commented Jan 11, 2025

We test the --repository output in the unit tests, but that option fails to
change the HTML output in the end-to-end tests. Upcoming patches will address
the incorrect behavior.

Copy link
Contributor Author

ilovepi commented Jan 11, 2025

@llvmbot
Copy link
Member

llvmbot commented Jan 11, 2025

@llvm/pr-subscribers-clang-tools-extra

Author: Paul Kirth (ilovepi)

Changes

We test the --repository output in the unit tests, but that option fails to
change the HTML output in the end-to-end tests. Upcoming patches will address
the incorrect behavior.


Full diff: https://github.com/llvm/llvm-project/pull/122565.diff

1 Files Affected:

  • (modified) clang-tools-extra/test/clang-doc/basic-project.test (+2-2)
diff --git a/clang-tools-extra/test/clang-doc/basic-project.test b/clang-tools-extra/test/clang-doc/basic-project.test
index 7c46c52bae687c..b6b43bb82bb15d 100644
--- a/clang-tools-extra/test/clang-doc/basic-project.test
+++ b/clang-tools-extra/test/clang-doc/basic-project.test
@@ -1,6 +1,6 @@
 // RUN: rm -rf %t && mkdir -p %t/docs %t/build
 // RUN: sed 's|$test_dir|%/S|g' %S/Inputs/basic-project/database_template.json > %t/build/compile_commands.json
-// RUN: clang-doc --format=html --output=%t/docs --executor=all-TUs %t/build/compile_commands.json
+// RUN: clang-doc --format=html --output=%t/docs --executor=all-TUs %t/build/compile_commands.json --repository=https://repository.com
 // RUN: FileCheck %s -input-file=%t/docs/index_json.js -check-prefix=JSON-INDEX
 // RUN: FileCheck %s -input-file=%t/docs/GlobalNamespace/Shape.html -check-prefix=HTML-SHAPE
 // RUN: FileCheck %s -input-file=%t/docs/GlobalNamespace/Calculator.html -check-prefix=HTML-CALC
@@ -286,4 +286,4 @@
 // MD-ALL-FILES: ## [GlobalNamespace](GlobalNamespace{{[\/]}}index.md)
 
 // MD-INDEX: #  C/C++ Reference
-// MD-INDEX: * Namespace: [GlobalNamespace](GlobalNamespace)
\ No newline at end of file
+// MD-INDEX: * Namespace: [GlobalNamespace](GlobalNamespace)

@ilovepi
Copy link
Contributor Author

ilovepi commented Feb 5, 2025

ping

@ilovepi ilovepi force-pushed the users/ilovepi/clang_doc_repo branch from fcf9e19 to 7700273 Compare February 6, 2025 18:57
Copy link
Contributor Author

ilovepi commented Feb 6, 2025

Merge activity

  • Feb 6, 1:58 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 6, 1:59 PM EST: Graphite rebased this pull request as part of a merge.
  • Feb 6, 2:03 PM EST: Graphite rebased this pull request as part of a merge.
  • Feb 6, 2:06 PM EST: A user merged this pull request with Graphite.

@ilovepi ilovepi force-pushed the users/ilovepi/clang_doc_repo branch from 7700273 to 872c3d0 Compare February 6, 2025 18:59
We test the `--repository` output in the unit tests, but that option fails to
change the HTML output in the end-to-end tests. Upcoming patches will address
the incorrect behavior.
@ilovepi ilovepi force-pushed the users/ilovepi/clang_doc_repo branch from 872c3d0 to e991e11 Compare February 6, 2025 19:03
@ilovepi ilovepi merged commit f8e53a9 into main Feb 6, 2025
5 of 7 checks passed
@ilovepi ilovepi deleted the users/ilovepi/clang_doc_repo branch February 6, 2025 19:06
Icohedron pushed a commit to Icohedron/llvm-project that referenced this pull request Feb 11, 2025
…#122565)

We test the `--repository` output in the unit tests, but that option fails to
change the HTML output in the end-to-end tests. Upcoming patches will address
the incorrect behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants