Fixed some warn-override tests in SemaCXX #122680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang Author: LoS (2LoS) ChangesFull diff: https://github.com/llvm/llvm-project/pull/122680.diff 3 Files Affected:
diff --git a/clang/test/SemaCXX/warn-inconsistent-missing-destructor-override b/clang/test/SemaCXX/warn-inconsistent-missing-destructor-override.cpp
similarity index 100%
rename from clang/test/SemaCXX/warn-inconsistent-missing-destructor-override
rename to clang/test/SemaCXX/warn-inconsistent-missing-destructor-override.cpp
diff --git a/clang/test/SemaCXX/warn-suggest-destructor-override b/clang/test/SemaCXX/warn-suggest-destructor-override.cpp
similarity index 100%
rename from clang/test/SemaCXX/warn-suggest-destructor-override
rename to clang/test/SemaCXX/warn-suggest-destructor-override.cpp
diff --git a/clang/test/SemaCXX/warn-suggest-override b/clang/test/SemaCXX/warn-suggest-override.cpp
similarity index 58%
rename from clang/test/SemaCXX/warn-suggest-override
rename to clang/test/SemaCXX/warn-suggest-override.cpp
index e06c939ff001fc..436a17d489693c 100644
--- a/clang/test/SemaCXX/warn-suggest-override
+++ b/clang/test/SemaCXX/warn-suggest-override.cpp
@@ -17,13 +17,13 @@ struct C {
struct D : public C {
void run();
- // expected-warning@-1 {{'run()' overrides a member function but is not marked 'override'}}
+ // expected-warning@-1 {{'run' overrides a member function but is not marked 'override'}}
~D();
};
struct E : public C {
virtual void run();
- // expected-warning@-1 {{'run()' overrides a member function but is not marked 'override'}}
+ // expected-warning@-1 {{'run' overrides a member function but is not marked 'override'}}
virtual ~E();
};
@@ -32,7 +32,8 @@ struct F : public C {
~F() override;
};
-struct G : public C {
+struct G : public C { // expected-note {{mark 'G' as 'final'}}
void run() final;
~G() final;
+ // expected-warning@-1 {{class with destructor marked as 'final' can not be inherited from}}
};
|
|
Thanks for spotting that! |
|
@cor3ntin , can you merge the pull request, please? |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/133/builds/9735 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.cppextension have been added to test files, so that they can be runned. Besides, thewarn-suggest-override.cpptests have been fixed.