-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[libc] implement unistd/getentropy #122692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SchrodingerZhu
merged 6 commits into
llvm:main
from
SchrodingerZhu:libc/src/unistd/getentropy
Jan 15, 2025
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
48a3a1c
[libc] implement unistd/getentropy
SchrodingerZhu 7dc7442
[libc] remove dependency from getentropy to getrandom
SchrodingerZhu bd91540
[libc] move unistd out of linux scope
SchrodingerZhu cb85833
format
SchrodingerZhu 68b6e3b
[libc] add windows implementation
SchrodingerZhu 4b3037a
[libc] address CRs
SchrodingerZhu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
//===-- Implementation header for getentropy ------------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "hdr/types/size_t.h" | ||
#include "src/__support/common.h" | ||
|
||
#ifndef LLVM_LIBC_SRC_UNISTD_GETENTROPY_H | ||
#define LLVM_LIBC_SRC_UNISTD_GETENTROPY_H | ||
|
||
namespace LIBC_NAMESPACE_DECL { | ||
int getentropy(void *buffer, size_t length); | ||
} | ||
|
||
#endif // LLVM_LIBC_SRC_UNISTD_GETENTROPY_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
//===-- Linux implementation of getentropy --------------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "src/unistd/getentropy.h" | ||
#include "hdr/errno_macros.h" | ||
#include "src/__support/common.h" | ||
#include "src/errno/libc_errno.h" | ||
#include "src/sys/random/getrandom.h" | ||
|
||
namespace LIBC_NAMESPACE_DECL { | ||
LLVM_LIBC_FUNCTION(int, getentropy, (void *buffer, size_t length)) { | ||
// check the length limit | ||
if (length > 256) { | ||
libc_errno = EIO; | ||
return -1; | ||
} | ||
|
||
char *cursor = static_cast<char *>(buffer); | ||
while (length != 0) { | ||
// 0 flag means urandom and blocking, which meets the assumption of | ||
// getentropy | ||
ssize_t ret = LIBC_NAMESPACE::getrandom(cursor, length, 0); | ||
SchrodingerZhu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
// on success, advance the buffer pointer | ||
if (ret != -1) { | ||
length -= static_cast<size_t>(ret); | ||
cursor += ret; | ||
continue; | ||
} | ||
|
||
// on EINTR, try again | ||
if (libc_errno == EINTR) | ||
continue; | ||
|
||
// on ENOSYS, forward errno and exit; | ||
// otherwise, set EIO and exit | ||
if (libc_errno != ENOSYS) | ||
libc_errno = EIO; | ||
return -1; | ||
} | ||
return 0; | ||
} | ||
} // namespace LIBC_NAMESPACE_DECL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
//===-- Unittests for getentropy ------------------------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "src/errno/libc_errno.h" | ||
#include "src/unistd/getentropy.h" | ||
#include "test/UnitTest/ErrnoSetterMatcher.h" | ||
#include "test/UnitTest/Test.h" | ||
|
||
using namespace LIBC_NAMESPACE::testing::ErrnoSetterMatcher; | ||
|
||
TEST(LlvmLibcUnistdGetEntropyTest, LengthTooLong) { | ||
char buf[1024]; | ||
ASSERT_THAT(LIBC_NAMESPACE::getentropy(buf, 257), Fails(EIO)); | ||
ASSERT_THAT(LIBC_NAMESPACE::getentropy(buf, 1024), Fails(EIO)); | ||
} | ||
|
||
TEST(LlvmLibcUnistdGetEntropyTest, SmokeTest) { | ||
char buf[256]; | ||
ASSERT_THAT(LIBC_NAMESPACE::getentropy(buf, 256), Succeeds()); | ||
ASSERT_THAT(LIBC_NAMESPACE::getentropy(buf, 0), Succeeds()); | ||
ASSERT_THAT(LIBC_NAMESPACE::getentropy(buf, 1), Succeeds()); | ||
ASSERT_THAT(LIBC_NAMESPACE::getentropy(buf, 16), Succeeds()); | ||
ASSERT_THAT(LIBC_NAMESPACE::getentropy(buf, 17), Succeeds()); | ||
SchrodingerZhu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
TEST(LlvmLibcUnistdGetEntropyTest, OtherError) { | ||
ASSERT_THAT(LIBC_NAMESPACE::getentropy(nullptr, 1), Fails(EIO)); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.