Skip to content

[TargetParser] Add missing include to modulemap #122768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

cyndyishida
Copy link
Member

Resolves warning when building with LLVM_ENABLE_MODULES

AArch64TargetParser.h:39:2: warning: missing submodule 'LLVM_Utils.TargetParser.AArch64FeatPriorities' [-Wincomplete-umbrella]
   39 | #include "llvm/TargetParser/AArch64FeatPriorities.inc"
      |  ^       ~~~~~~~

Resolves warning when building with `LLVM_ENABLE_MODULES`

```
AArch64TargetParser.h:39:2: warning: missing submodule 'LLVM_Utils.TargetParser.AArch64FeatPriorities' [-Wincomplete-umbrella]
   39 | #include "llvm/TargetParser/AArch64FeatPriorities.inc"
      |  ^       ~~~~~~~
```
Copy link
Contributor

@qiongsiwu qiongsiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@cyndyishida cyndyishida merged commit dcc141b into llvm:main Jan 14, 2025
9 checks passed
@cyndyishida cyndyishida deleted the eng/PR-modulesBug branch January 14, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants