-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[clang] document that by default FP turned off for ARM baremetal #122881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@llvm/pr-subscribers-clang Author: Ties Stuij (stuij) ChangesAs per #117140. Full diff: https://github.com/llvm/llvm-project/pull/122881.diff 1 Files Affected:
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index 794943b24a003c..663e7561f715c0 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -1076,6 +1076,8 @@ Arm and AArch64 Support
in leaf functions after enabling ``-fno-omit-frame-pointer``, you can do so by adding
the ``-momit-leaf-frame-pointer`` option.
+- For ARM baremetal targets, the frame pointer (FP) is now turned off by default.
+
- Support has been added for the following processors (-mcpu identifiers in parenthesis):
For AArch64:
|
clang/docs/ReleaseNotes.rst
Outdated
@@ -1076,6 +1076,8 @@ Arm and AArch64 Support | |||
in leaf functions after enabling ``-fno-omit-frame-pointer``, you can do so by adding | |||
the ``-momit-leaf-frame-pointer`` option. | |||
|
|||
- For ARM baremetal targets, the frame pointer (FP) is now turned off by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move this before the one above and add to this "To enable the frame pointer use the -fno-omit-frame-pointer
option.". I know it's stated again in the second one, but it answers the "how do I get the old way" question more obviously.
If I am not someone who ever cared to disable FP, I won't understand / care to understand what the leaf function stuff means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -1071,6 +1071,10 @@ Arm and AArch64 Support | |||
- Implementation of SVE2.1 and SME2.1 in accordance with the Arm C Language | |||
Extensions (ACLE) is now available. | |||
|
|||
- For ARM baremetal targets, the frame pointer (FP) is now turned off by | |||
default. To turn on frame pointers for Arm baremetal targets, use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arm -> ARM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As per #117140.