[Hexagon] Add default clang symlinks to CLANG_LINKS_TO_CREATE #123011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this cache value overrides the defaults, we end up with
`clang` linked to `clang-20`, and some `${triple}-clang*` links,
but we're missing `clang++`. This makes for a toolchain with
inconsistent behavior when used in someone's `$PATH`.
We'll add the default symlinks to our list so that C and C++ programs are both
built as expected when `clang` and `clang++` are invoked.
|
@llvm/pr-subscribers-clang Author: Brian Cain (androm3da) ChangesSince this cache value overrides the defaults, we end up with We'll add the default symlinks to our list so that C and C++ programs are both built as expected when Full diff: https://github.com/llvm/llvm-project/pull/123011.diff 1 Files Affected:
diff --git a/clang/cmake/caches/hexagon-unknown-linux-musl-clang-cross.cmake b/clang/cmake/caches/hexagon-unknown-linux-musl-clang-cross.cmake
index 91bbe26b621054..fd2aeec819fc01 100644
--- a/clang/cmake/caches/hexagon-unknown-linux-musl-clang-cross.cmake
+++ b/clang/cmake/caches/hexagon-unknown-linux-musl-clang-cross.cmake
@@ -10,6 +10,9 @@ set(CLANG_LINKS_TO_CREATE
hexagon-none-elf-clang
hexagon-unknown-none-elf-clang++
hexagon-unknown-none-elf-clang
+ clang++
+ clang-cl
+ clang-cpp
CACHE STRING "")
set(LLVM_INSTALL_TOOLCHAIN_ONLY ON CACHE BOOL "")
|
SidManning
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this cache value overrides the defaults, we end up with
clanglinked toclang-20, and some${triple}-clang*links, but we're missingclang++. This makes for a toolchain with inconsistent behavior when used in someone's$PATH.We'll add the default symlinks to our list so that C and C++ programs are both built as expected when
clangandclang++are invoked.