[AArch64] Return early rather than asserting when Size of value passed to targetShrinkDemandedConstant is not 32 or 64

[WillFroom]

See #123029 for details.

[llvmbot]

@llvm/pr-subscribers-backend-aarch64

Author: Will Froom (WillFroom)

Changes

See #123029 for details.

---

Full diff: https://github.com/llvm/llvm-project/pull/123084.diff

1 Files Affected:

• (modified) llvm/lib/Target/AArch64/AArch64ISelLowering.cpp (+5-2)

diff --git a/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp b/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
index d4a114c275fb76..32abcfe7a8f452 100644
--- a/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
+++ b/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
@@ -2373,8 +2373,11 @@ bool AArch64TargetLowering::targetShrinkDemandedConstant(
     return false;
 
   unsigned Size = VT.getSizeInBits();
-  assert((Size == 32 || Size == 64) &&
-         "i32 or i64 is expected after legalization.");
+
+  if((Size != 32 || Size != 64))
+  {
+    return false;
+  }
 
   // Exit early if we demand all bits.
   if (DemandedBits.popcount() == Size)

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[davemgreen]

Thanks for doing this, it sounds like the right place to change to me. Could you add the test case from #123029?

[WillFroom]

@davemgreen I've added a test that does no more than simply run the compilation pipeline with no explicit checks, let me know if you are happy with that (I have confirmed that it fails prior to my change)

[davemgreen]

Thanks, I have some nitpicks over cleaning up the test a little, but otherwise LGTM.

[WillFroom]

@davemgreen thanks for the review, I am waiting on commit access (#122733) so if you are happy could you press merge, cheers.

[davemgreen]

Thanks