Skip to content

[lldb] Handle a byte size of zero in CompilerType::GetValueAsScalar #123107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2025
Merged

[lldb] Handle a byte size of zero in CompilerType::GetValueAsScalar #123107

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f83e29d
[lldb] Handle a byte size of zero in CompilerType::GetValueAsScalar
JDevlieghere Jan 15, 2025
0c3d07e
Add comment
JDevlieghere Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lldb/source/Symbol/CompilerType.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,8 +1105,11 @@ bool CompilerType::GetValueAsScalar(const lldb_private::DataExtractor &data,
return false;

std::optional<uint64_t> byte_size = GetByteSize(exe_scope);
if (!byte_size)
// A bit or byte size of 0 is not a bug, but it doesn't make sense to read a
// scalar of zero size.
if (!byte_size || *byte_size == 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I would add a comment with brief context on how this appears invalid. Otherwise LGTM

return false;

lldb::offset_t offset = data_byte_offset;
switch (encoding) {
case lldb::eEncodingInvalid:
Expand Down
Loading