[AArch64] Correct defs and uses on {PAC,AUT}I{A,B}171615 #123354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not adding tests for this, as I don't think we usually have tests to verify correct description of defs and uses in instructions? This fix will be tested when llvm#122304 lands, as one of the regression tests in that PR fails without this fix.
|
@llvm/pr-subscribers-backend-aarch64 Author: Kristof Beyls (kbeyls) ChangesI'm not adding tests for this, as I don't think we usually have tests to verify correct description of defs and uses in instructions? This fix will be tested when #122304 lands, as one of the regression tests in that PR fails without this fix. Full diff: https://github.com/llvm/llvm-project/pull/123354.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AArch64/AArch64InstrInfo.td b/llvm/lib/Target/AArch64/AArch64InstrInfo.td
index 8215f3a4fdae1e..40a6b8e4c8e640 100644
--- a/llvm/lib/Target/AArch64/AArch64InstrInfo.td
+++ b/llvm/lib/Target/AArch64/AArch64InstrInfo.td
@@ -2030,6 +2030,8 @@ let Predicates = [HasPAuthLR] in {
// opcode2, opcode, asm
def AUTIASPPCr : SignAuthOneReg<0b00001, 0b100100, "autiasppcr">;
def AUTIBSPPCr : SignAuthOneReg<0b00001, 0b100101, "autibsppcr">;
+ }
+ let Defs = [X17], Uses = [X15, X16, X17] in {
// opcode2, opcode, asm
def PACIA171615 : SignAuthFixedRegs<0b00001, 0b100010, "pacia171615">;
def PACIB171615 : SignAuthFixedRegs<0b00001, 0b100011, "pacib171615">;
|
tmatheson-arm
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not adding tests for this, as I don't think we usually have tests to verify correct description of defs and uses in instructions?
This fix will be tested when #122304 lands, as one of the regression tests in that PR fails without this fix.