[CodeGen] NFC: Move isDead to MachineInstr #123531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #117247 for a usecase |
arsenm
reviewed
Jan 22, 2025
Change-Id: I90e7829a0afc535760c08417cc50db71f46d9910
arsenm
approved these changes
Jan 23, 2025
|
Looks like this causes a small compile-time regression: https://llvm-compile-time-tracker.com/compare.php?from=76ed4b1cec57ad26433e4808697d6c4d042d4b22&to=f2942b90778670d9ad974d025c779fc96afa737c&stat=instructions:u It looks like this not only moves the code, but also changes the order of the checks -- it's possible that the new order is less optimal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide isDead interface for access to ad-hoc isDead queries. LivePhysRegs is optional: if not provided, pessimistically check deadness of a single MI without doing the LivePhysReg walk; if provided it is assumed to be at the position of MI.