Skip to content

Revert "[SPIR-V] Add SPIRV to LLVM_ALL_TARGETS" #123532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

michalpaszkowski
Copy link
Member

Reverts #119653

@llvmbot
Copy link
Member

llvmbot commented Jan 19, 2025

@llvm/pr-subscribers-github-workflow

Author: Michal Paszkowski (michalpaszkowski)

Changes

Reverts llvm/llvm-project#119653


Full diff: https://github.com/llvm/llvm-project/pull/123532.diff

4 Files Affected:

  • (modified) .github/workflows/spirv-tests.yml (+1-1)
  • (modified) llvm/CMakeLists.txt (+1-1)
  • (modified) llvm/Maintainers.md (+2-5)
  • (modified) llvm/docs/ReleaseNotes.md (-6)
diff --git a/.github/workflows/spirv-tests.yml b/.github/workflows/spirv-tests.yml
index ea466dc6c52e57..34c77a398c1504 100644
--- a/.github/workflows/spirv-tests.yml
+++ b/.github/workflows/spirv-tests.yml
@@ -25,5 +25,5 @@ jobs:
     with:
       build_target: check-llvm-codegen-spirv
       projects:
-      extra_cmake_args: '-DLLVM_TARGETS_TO_BUILD="SPIRV" -DLLVM_INCLUDE_SPIRV_TOOLS_TESTS=ON'
+      extra_cmake_args: '-DLLVM_TARGETS_TO_BUILD="" -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD="SPIRV" -DLLVM_INCLUDE_SPIRV_TOOLS_TESTS=ON'
       os_list: '["ubuntu-22.04"]'
diff --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt
index ad12100fdb5b89..f14065ab037990 100644
--- a/llvm/CMakeLists.txt
+++ b/llvm/CMakeLists.txt
@@ -486,7 +486,6 @@ set(LLVM_ALL_TARGETS
   PowerPC
   RISCV
   Sparc
-  SPIRV
   SystemZ
   VE
   WebAssembly
@@ -499,6 +498,7 @@ set(LLVM_ALL_EXPERIMENTAL_TARGETS
   CSKY
   DirectX
   M68k
+  SPIRV
   Xtensa
 )
 
diff --git a/llvm/Maintainers.md b/llvm/Maintainers.md
index 2e995dc27dcd04..74dcc5abf5645e 100644
--- a/llvm/Maintainers.md
+++ b/llvm/Maintainers.md
@@ -284,11 +284,8 @@ [email protected] (email), [koachan](https://github.com/koachan) (GitHub)
 
 #### SPIRV backend
 
-Vyacheslav Levytskyy \
-[email protected], [email protected] (email), [VyacheslavLevytskyy](https://github.com/VyacheslavLevytskyy) (GitHub)
-
-Nathan Gauër \
-[email protected] (email), [Keenuts](https://github.com/Keenuts) (GitHub)
+Ilia Diachkov \
+[email protected] (email), [iliya-diyachkov](https://github.com/iliya-diyachkov) (GitHub)
 
 #### SystemZ backend
 
diff --git a/llvm/docs/ReleaseNotes.md b/llvm/docs/ReleaseNotes.md
index 48f962d212e86d..8f88b824f965aa 100644
--- a/llvm/docs/ReleaseNotes.md
+++ b/llvm/docs/ReleaseNotes.md
@@ -47,12 +47,6 @@ for adding a new subsection. -->
   same semantics. The normalizer makes it easier to spot semantic differences
   when diffing two modules which have undergone different passes.
 
-* The SPIR-V backend is now an official LLVM target, providing OpenCL and SYCL
-  conformance and establishing a foundation for broader applicability to other
-  APIs, including Vulkan, GLSL, and HLSL. This backend aims to offer a unified
-  approach for diverse compute and graphics workloads, providing a robust
-  alternative to the Khronos SPIR-V LLVM Translator.
-
 * ...
 
 <!-- If you would like to document a larger change, then you can add a

@michalpaszkowski michalpaszkowski merged commit 5af7905 into main Jan 19, 2025
9 of 12 checks passed
@michalpaszkowski michalpaszkowski deleted the revert-119653-feature_make_spirv_backend_nonexperimental branch January 19, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants