Skip to content

[flang][PPC] XFAIL unroll-loops on PPC #123661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2025
Merged

[flang][PPC] XFAIL unroll-loops on PPC #123661

merged 1 commit into from
Jan 20, 2025

Conversation

mustartt
Copy link
Member

xfail the following 2 test cases that are currently failing on ppc64-flang-aix and ppc64le-flang-rhel-clang starting on #122906

FAIL: Flang::unroll-loops.fir
FAIL: Flang::unroll-loops.f90

@llvmbot llvmbot added the flang Flang issues not falling into any other category label Jan 20, 2025
kiranchandramohan
kiranchandramohan approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@kiranchandramohan kiranchandramohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Thanks.

kamaub
kamaub approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@kamaub kamaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can merge it for you once the FIXME is amended.

flang/test/HLFIR/unroll-loops.fir Outdated
@@ -3,6 +3,9 @@
// RUN: %flang_fc1 -emit-llvm -O1 -fno-unroll-loops -mllvm -force-vector-width=2 -o- %s | FileCheck %s --check-prefixes=CHECK,NO-UNROLL
// RUN: %flang_fc1 -emit-llvm -O1 -mllvm -force-vector-width=2 -o- %s | FileCheck %s --check-prefixes=CHECK,NO-UNROLL

// FIXME: Investigate and fix.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we open an issue and assign the author @DavidTruby to it and add that issue number here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out.

@kamaub kamaub merged commit 2f1bc68 into llvm:main Jan 20, 2025
5 of 7 checks passed
kamaub pushed a commit that referenced this pull request Jan 21, 2025
@mustartt
[Flang][PPC] XFAIL -funroll-loops to include both powerpc64 and pow…
7c91435 
…erpc64le target (#123672)

Include both `powerpc64` and `powerpc64le` target to XFAIL for the 2
test cases that are currently failing on `ppc64-flang-aix` and
`ppc64le-flang-rhel-clang`. A follow-up PR to #123661.

```
FAIL: Flang::unroll-loops.fir
FAIL: Flang::unroll-loops.f90
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranchandramohan kiranchandramohan kiranchandramohan approved these changes

@kamaub kamaub kamaub approved these changes

Assignees
No one assigned
Labels
flang Flang issues not falling into any other category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mustartt @kiranchandramohan @kamaub @llvmbot