Revert "[SPIR-V] Add SPIRV to LLVM_ALL_TARGETS (reapply)" #123674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f427fef.
|
@llvm/pr-subscribers-github-workflow Author: Michal Paszkowski (michalpaszkowski) ChangesReverts llvm/llvm-project#123654 due to buildbot issue Full diff: https://github.com/llvm/llvm-project/pull/123674.diff 4 Files Affected:
diff --git a/.github/workflows/spirv-tests.yml b/.github/workflows/spirv-tests.yml
index ea466dc6c52e57..34c77a398c1504 100644
--- a/.github/workflows/spirv-tests.yml
+++ b/.github/workflows/spirv-tests.yml
@@ -25,5 +25,5 @@ jobs:
with:
build_target: check-llvm-codegen-spirv
projects:
- extra_cmake_args: '-DLLVM_TARGETS_TO_BUILD="SPIRV" -DLLVM_INCLUDE_SPIRV_TOOLS_TESTS=ON'
+ extra_cmake_args: '-DLLVM_TARGETS_TO_BUILD="" -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD="SPIRV" -DLLVM_INCLUDE_SPIRV_TOOLS_TESTS=ON'
os_list: '["ubuntu-22.04"]'
diff --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt
index ad12100fdb5b89..f14065ab037990 100644
--- a/llvm/CMakeLists.txt
+++ b/llvm/CMakeLists.txt
@@ -486,7 +486,6 @@ set(LLVM_ALL_TARGETS
PowerPC
RISCV
Sparc
- SPIRV
SystemZ
VE
WebAssembly
@@ -499,6 +498,7 @@ set(LLVM_ALL_EXPERIMENTAL_TARGETS
CSKY
DirectX
M68k
+ SPIRV
Xtensa
)
diff --git a/llvm/Maintainers.md b/llvm/Maintainers.md
index 534d81e68d0245..56457946136f04 100644
--- a/llvm/Maintainers.md
+++ b/llvm/Maintainers.md
@@ -284,11 +284,8 @@ [email protected] (email), [koachan](https://github.com/koachan) (GitHub)
#### SPIRV backend
-Vyacheslav Levytskyy \
-[email protected], [email protected] (email), [VyacheslavLevytskyy](https://github.com/VyacheslavLevytskyy) (GitHub)
-
-Nathan Gauër \
-[email protected] (email), [Keenuts](https://github.com/Keenuts) (GitHub)
+Ilia Diachkov \
+[email protected] (email), [iliya-diyachkov](https://github.com/iliya-diyachkov) (GitHub)
#### SystemZ backend
diff --git a/llvm/docs/ReleaseNotes.md b/llvm/docs/ReleaseNotes.md
index 48f962d212e86d..8f88b824f965aa 100644
--- a/llvm/docs/ReleaseNotes.md
+++ b/llvm/docs/ReleaseNotes.md
@@ -47,12 +47,6 @@ for adding a new subsection. -->
same semantics. The normalizer makes it easier to spot semantic differences
when diffing two modules which have undergone different passes.
-* The SPIR-V backend is now an official LLVM target, providing OpenCL and SYCL
- conformance and establishing a foundation for broader applicability to other
- APIs, including Vulkan, GLSL, and HLSL. This backend aims to offer a unified
- approach for diverse compute and graphics workloads, providing a robust
- alternative to the Khronos SPIR-V LLVM Translator.
-
* ...
<!-- If you would like to document a larger change, then you can add a
|
michalpaszkowski
deleted the
revert-123654-feature_make_spirv_backend_nonexperimental2
branch
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/20309 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #123654 due to buildbot issue