Skip to content

[AMDGPU][CodeGen] SILowerWWMCopies: Declare used analyses #123710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

optimisan
Copy link
Contributor

@optimisan optimisan commented Jan 21, 2025

This prevents legacy PM from mistakenly removing these analyses if SILowerWWMCopies is the last user of them. (it removes dead analyses after its last use)

Copy link
Contributor Author

optimisan commented Jan 21, 2025

@optimisan optimisan changed the title [AMDGPU][CodeGen] Add used analyses to SILowerWWMCopies [AMDGPU][CodeGen] Declare used analyses to SILowerWWMCopies Jan 21, 2025
@optimisan optimisan changed the title [AMDGPU][CodeGen] Declare used analyses to SILowerWWMCopies [AMDGPU][CodeGen] SILowerWWMCopies: Declare used analyses Jan 21, 2025
@optimisan optimisan force-pushed the users/Akshat-Oke/si-lower-wwm-au-info branch from b7b609e to 7b4cefb Compare January 21, 2025 08:38
@optimisan optimisan marked this pull request as ready for review January 21, 2025 08:42
@llvmbot
Copy link
Member

llvmbot commented Jan 21, 2025

@llvm/pr-subscribers-backend-amdgpu

Author: Akshat Oke (optimisan)

Changes

This prevents legacy PM from mistakenly removing these analyses if SILowerWWMCopies is the last user of them. (it removes dead analyses after its last use)


Full diff: https://github.com/llvm/llvm-project/pull/123710.diff

1 Files Affected:

  • (modified) llvm/lib/Target/AMDGPU/SILowerWWMCopies.cpp (+3)
diff --git a/llvm/lib/Target/AMDGPU/SILowerWWMCopies.cpp b/llvm/lib/Target/AMDGPU/SILowerWWMCopies.cpp
index c663820311b8ce..d80a5f958273a9 100644
--- a/llvm/lib/Target/AMDGPU/SILowerWWMCopies.cpp
+++ b/llvm/lib/Target/AMDGPU/SILowerWWMCopies.cpp
@@ -43,6 +43,9 @@ class SILowerWWMCopies : public MachineFunctionPass {
   StringRef getPassName() const override { return "SI Lower WWM Copies"; }
 
   void getAnalysisUsage(AnalysisUsage &AU) const override {
+    AU.addUsedIfAvailable<LiveIntervalsWrapperPass>();
+    AU.addUsedIfAvailable<SlotIndexesWrapperPass>();
+    AU.addUsedIfAvailable<VirtRegMapWrapperLegacy>();
     AU.setPreservesAll();
     MachineFunctionPass::getAnalysisUsage(AU);
   }

@optimisan optimisan merged commit 7acad68 into main Jan 21, 2025
11 checks passed
@optimisan optimisan deleted the users/Akshat-Oke/si-lower-wwm-au-info branch January 21, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants