Skip to content

[libc][workflow] improve ci coverage with windows-2025 and arm ubuntu #123745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 24, 2025
Merged

[libc][workflow] improve ci coverage with windows-2025 and arm ubuntu #123745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ef0df0
[libc][workflow] improve ci coverage with windows-2024 and arm ubuntu
SchrodingerZhu Jan 21, 2025
d26214b
skip ccache on arm64
SchrodingerZhu Jan 21, 2025
5527418
address CR
SchrodingerZhu Jan 21, 2025
6259b5e
fix build
SchrodingerZhu Jan 21, 2025
d62e81e
address CR
SchrodingerZhu Jan 24, 2025
cdb31e0
Merge branch 'main' into libc-workflow-win2025-linuxarm
SchrodingerZhu Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions .github/workflows/libc-fullbuild-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,19 @@ on:

jobs:
build:
runs-on: ubuntu-24.04
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
include:
- c_compiler: clang
- os: ubuntu-24.04
ccache-variant: sccache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use sccache for this, but ccache for the arm variant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sccache is a modern implementation from Mozilla, it supports more storage format and compiler (e.g. msvc/clang-cl). I prefer to default on sccache but due to hendrikmuhs/ccache-action#279, ccache is used on arm64 ubuntu.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment linking to that issue in the yml file. I assume it will be resolved some day, so if someone notices that in the future, it would be good to then resolve the arm specific differences.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

c_compiler: clang
cpp_compiler: clang++
# TODO: remove ccache logic when https://github.com/hendrikmuhs/ccache-action/issues/279 is resolved.
- os: ubuntu-24.04-arm
ccache-variant: ccache
c_compiler: clang
cpp_compiler: clang++
# TODO: add back gcc build when it is fixed
# - c_compiler: gcc
Expand All @@ -35,7 +42,7 @@ jobs:
with:
max-size: 1G
key: libc_fullbuild_${{ matrix.c_compiler }}
variant: sccache
variant: ${{ matrix.ccache-variant }}

# Notice:
# - MPFR is required by some of the mathlib tests.
Expand All @@ -62,8 +69,8 @@ jobs:
-DCMAKE_CXX_COMPILER=${{ matrix.cpp_compiler }}
-DCMAKE_C_COMPILER=${{ matrix.c_compiler }}
-DCMAKE_BUILD_TYPE=MinSizeRel
-DCMAKE_C_COMPILER_LAUNCHER=sccache
-DCMAKE_CXX_COMPILER_LAUNCHER=sccache
-DCMAKE_C_COMPILER_LAUNCHER=${{ matrix.ccache-variant }}
-DCMAKE_CXX_COMPILER_LAUNCHER=${{ matrix.ccache-variant }}
-DCMAKE_INSTALL_PREFIX=${{ steps.strings.outputs.build-install-dir }}
-DLLVM_ENABLE_RUNTIMES="libc;compiler-rt"
-DLLVM_LIBC_FULL_BUILD=ON
Expand Down
20 changes: 17 additions & 3 deletions .github/workflows/libc-overlay-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,28 @@ jobs:
include:
# TODO: add linux gcc when it is fixed
- os: ubuntu-24.04
ccache-variant: sccache
compiler:
c_compiler: clang
cpp_compiler: clang++
# TODO: remove ccache logic when https://github.com/hendrikmuhs/ccache-action/issues/279 is resolved.
- os: ubuntu-24.04-arm
ccache-variant: ccache
compiler:
c_compiler: clang
cpp_compiler: clang++
- os: windows-2022
ccache-variant: sccache
compiler:
c_compiler: clang-cl
cpp_compiler: clang-cl
- os: windows-2025
ccache-variant: sccache
compiler:
c_compiler: clang-cl
cpp_compiler: clang-cl
- os: macos-14
ccache-variant: sccache
compiler:
c_compiler: clang
cpp_compiler: clang++
Expand All @@ -46,7 +60,7 @@ jobs:
with:
max-size: 1G
key: libc_overlay_build_${{ matrix.os }}_${{ matrix.compiler.c_compiler }}
variant: sccache
variant: ${{ matrix.ccache-variant }}

# MPFR is required by some of the mathlib tests.
- name: Prepare dependencies (Ubuntu)
Expand Down Expand Up @@ -82,8 +96,8 @@ jobs:
-DCMAKE_CXX_COMPILER=${{ matrix.compiler.cpp_compiler }}
-DCMAKE_C_COMPILER=${{ matrix.compiler.c_compiler }}
-DCMAKE_BUILD_TYPE=MinSizeRel
-DCMAKE_C_COMPILER_LAUNCHER=sccache
-DCMAKE_CXX_COMPILER_LAUNCHER=sccache
-DCMAKE_C_COMPILER_LAUNCHER=${{ matrix.ccache-variant }}
-DCMAKE_CXX_COMPILER_LAUNCHER=${{ matrix.ccache-variant }}
-DCMAKE_POLICY_DEFAULT_CMP0141=NEW
-DCMAKE_MSVC_DEBUG_INFORMATION_FORMAT=Embedded
-DLLVM_ENABLE_RUNTIMES=libc
Expand Down
Loading