Skip to content

[libc][cpio] Add cpio.h header. #123798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 24, 2025
Merged

[libc][cpio] Add cpio.h header. #123798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ed3453c
Document POSIX header cpio.h
Jan 21, 2025
b207e43
Document POSIX header cpio.h
Jan 21, 2025
9e75b3e
Document POSIX header cpio.h
Jan 24, 2025
777e97e
Merge branch 'main' into main
siya100 Jan 24, 2025
36f0a3e
Merge branch 'main' into main
siya100 Jan 24, 2025
2c5b6aa
Update cpio.yaml
siya100 Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libc/docs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ if (SPHINX_FOUND)
aio
arpa/inet
assert
cpio
ctype
errno
fenv
Expand Down
1 change: 1 addition & 0 deletions libc/docs/headers/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Implementation Status
arpa/inet
assert
complex
cpio
ctype
errno
fenv
Expand Down
44 changes: 44 additions & 0 deletions libc/utils/docgen/cpio.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
macros:
C_IRUSR:
in-latest-posix: ''
C_IWUSR:
in-latest-posix: ''
C_IXUSR:
in-latest-posix: ''
C_IRGRP:
in-latest-posix: ''
C_IWGRP:
in-latest-posix: ''
C_IXGRP:
in-latest-posix: ''
C_IROTH:
in-latest-posix: ''
C_IWOTH:
in-latest-posix: ''
C_IXOTH:
in-latest-posix: ''
C_ISUID:
in-latest-posix: ''
C_ISGID:
in-latest-posix: ''
C_ISVTX:
in-latest-posix: ''
C_ISDIR:
in-latest-posix: ''
C_ISFIFO:
in-latest-posix: ''
C_ISREG:
in-latest-posix: ''
C_ISBLK:
in-latest-posix: ''
C_ISCHR:
in-latest-posix: ''
C_ISCTG:
in-latest-posix: ''
C_ISLNK:
in-latest-posix: ''
C_ISSOCK:
in-latest-posix: ''
MAGIC:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that be here?

I came to this review because that user posted a comment that looked suspiciously like spam and saw they had contributed to LLVM in this PR. From one of their comments, it looks like this user may be contributing AI-generated stuff. There's nothing wrong with that in theory, but I'd advise doing careful review of these diffs. If you think I'm being needlessly careful here, feel free to let me know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/cpio.h.html

The <cpio.h> header shall define the following symbolic constant as a string:
MAGIC "070707"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks, I missed that!

in-latest-posix: ''

Loading