-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[llvm][Support] Only enable backtrace test when it's enabled #123852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lld and clang already do this, so can we make it the same as they do? I.e. use ENABLE_BACKTRACE instead of LLVM_ENABLE_BACKTRACE (though really, the exported name should be renamed to have the LLVM prefix...) and name the feature backtrace
? lld/clang also do the feature addition in lit.cfg.py and only assign the value from cmake in lit.site.cfg.py.in.
sure, I can make those adjustments |
rdar://138554797
e11a598
to
5511f69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/50/builds/9238 Here is the relevant piece of the build log for the reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rdar://138554797