[flang][NFC] Restrict -funroll-loops tests to known working targets #123939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mustartt did you intend the issue to be for the failing tests or that the flag does not produce the intended result on powerpc? |
I intended for the issue to be just for the failing test cases. I investigated the issue and unrolling is working as expected. But at different unroll count and different interleave with an unchecked add for incrementing the index indvar. On PPC we get unroll factor of 8 with vector width of 2. Feel free to commit this, but leave the issue open for now and I can make the tests a bit more generic. |
mustartt
approved these changes
Jan 22, 2025
tblah
approved these changes
Jan 22, 2025
|
I think it's generally frowned upon to have test cases without From the linked issue, I think it is working on PPC, but it's just unrolling much more aggressively than here. At a glance it looks like it's unrolling 8 iterations at a time instead of just 2 like aarch64 and x86_64. I wonder if there's a |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/157/builds/18291 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/89/builds/15256 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/140/builds/15622 Here is the relevant piece of the build log for the reference |
|
The |
|
Interesting. Why are we not able to output as far as LLVM IR without having the backend registered? |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/80/builds/9242 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/29/builds/9549 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/50/builds/9448 Here is the relevant piece of the build log for the reference |
DavidTruby
added a commit
that referenced
this pull request
Jan 27, 2025
github-actions bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jan 27, 2025
…n working targets" (#124536) Reverts llvm/llvm-project#123939
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/201/builds/2242 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If -funroll-loops tests are not restricted to specific targets the tests may behave differently based on the host platform. This patch restricts the tests to aarch64 and x86_64, and removes the PowerPC XFAIL.