Skip to content

[compiler-rt] Deprecate LLVM_ENABLE_PROJECTS in favor of LLVM_ENABLE_RUNTIMES #124016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2025
Merged

[compiler-rt] Deprecate LLVM_ENABLE_PROJECTS in favor of LLVM_ENABLE_RUNTIMES #124016

merged 2 commits into from
Jan 28, 2025

Conversation

petrhosek
Copy link
Member

We plan to make this a hard error in the LLVM 21 release.

Link #124012

@petrhosek
[compiler-rt] Deprecate LLVM_ENABLE_PROJECTS in favor of LLVM_ENABLE_…
379cc60 
…RUNTIMES

We plan to make this a hard error in the LLVM 21 release.

Link llvm#124012
@petrhosek petrhosek requested a review from vitalybuka January 22, 2025 21:31
@nickdesaulniers nickdesaulniers self-requested a review January 22, 2025 23:51
@nickdesaulniers
Copy link
Member

Do we have release notes for some of the libraries mentioned in the sister issues you just filed?

@petrhosek petrhosek merged commit b593110 into llvm:main Jan 28, 2025
6 of 8 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Jan 28, 2025

LLVM Buildbot has detected a new failure on builder flang-aarch64-dylib running on linaro-flang-aarch64-dylib while building llvm at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/50/builds/9490

Here is the relevant piece of the build log for the reference 
Step 5 (build-unified-tree) failure: build (failure)
...
1017.034 [1720/1/5103] Building CXX object tools/mlir/lib/Dialect/Index/IR/CMakeFiles/obj.MLIRIndexDialect.dir/IndexAttrs.cpp.o
1017.338 [1719/1/5104] Building CXX object tools/mlir/lib/ExecutionEngine/CMakeFiles/MLIRExecutionEngineShared.dir/ExecutionEngine.cpp.o
1017.607 [1718/1/5105] Building CXX object tools/mlir/lib/Dialect/IRDL/CMakeFiles/obj.MLIRIRDL.dir/IRDLVerifiers.cpp.o
1017.855 [1717/1/5106] Building CXX object tools/mlir/lib/Dialect/Linalg/IR/CMakeFiles/obj.MLIRLinalgDialect.dir/LinalgDialect.cpp.o
1017.956 [1716/1/5107] Building CXX object tools/mlir/lib/Dialect/Linalg/IR/CMakeFiles/obj.MLIRLinalgDialect.dir/LinalgInterfaces.cpp.o
1018.110 [1715/1/5108] Building CXX object tools/mlir/lib/CAPI/Dialect/CMakeFiles/obj.MLIRCAPIArith.dir/Arith.cpp.o
1018.244 [1714/1/5109] Building CXX object tools/mlir/lib/Dialect/Linalg/IR/CMakeFiles/obj.MLIRLinalgDialect.dir/ValueBoundsOpInterfaceImpl.cpp.o
1018.416 [1713/1/5110] Building CXX object tools/mlir/lib/Dialect/Linalg/IR/CMakeFiles/obj.MLIRLinalgDialect.dir/LinalgOps.cpp.o
1018.679 [1712/1/5111] Building CXX object tools/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestVisitors.cpp.o
1027.786 [1711/1/5112] Building CXX object tools/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestVisitorsGeneric.cpp.o
FAILED: tools/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestVisitorsGeneric.cpp.o 
/usr/local/bin/c++ -DGTEST_HAS_RTTI=0 -DMLIR_INCLUDE_TESTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/flang-aarch64-dylib/build/tools/mlir/test/lib/IR -I/home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/IR -I/home/tcwg-buildbot/worker/flang-aarch64-dylib/build/tools/mlir/include -I/home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/include -I/home/tcwg-buildbot/worker/flang-aarch64-dylib/build/include -I/home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/llvm/include -I/home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/IR/../Dialect/Test -I/home/tcwg-buildbot/worker/flang-aarch64-dylib/build/tools/mlir/test/lib/IR/../Dialect/Test -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Werror=mismatched-tags -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestVisitorsGeneric.cpp.o -MF tools/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestVisitorsGeneric.cpp.o.d -o tools/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestVisitorsGeneric.cpp.o -c /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/IR/TestVisitorsGeneric.cpp
In file included from /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/IR/TestVisitorsGeneric.cpp:9:
/home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/IR/../Dialect/Test/TestOps.h:148:10: fatal error: 'TestOps.h.inc' file not found
  148 | #include "TestOps.h.inc"
      |          ^~~~~~~~~~~~~~~
1 error generated.
ninja: build stopped: subcommand failed.

@llvm-ci
Copy link
Collaborator

llvm-ci commented Jan 28, 2025

LLVM Buildbot has detected a new failure on builder sanitizer-ppc64le-linux running on ppc64le-sanitizer while building llvm at step 2 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/7638

Here is the relevant piece of the build log for the reference 
Step 2 (annotate) failure: 'python ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py' (failure) (timed out)
...
PASS: SanitizerCommon-tsan-powerpc64le-Linux :: Linux/signal_segv_handler.cpp (4870 of 4880)
PASS: SanitizerCommon-msan-powerpc64le-Linux :: Linux/signal_segv_handler.cpp (4871 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-inline-Dynamic-Test/40/96 (4872 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-inline-Test/40/96 (4873 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-calls-Dynamic-Test/40/96 (4874 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-calls-Test/40/96 (4875 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-calls-Test/68/96 (4876 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-inline-Dynamic-Test/68/96 (4877 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-inline-Test/68/96 (4878 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-calls-Dynamic-Test/68/96 (4879 of 4880)
command timed out: 1800 seconds without output running [b'python', b'../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=3433.308728
Step 12 (test compiler-rt default) failure: test compiler-rt default (failure)
...
PASS: UBSan-ThreadSanitizer-powerpc64le :: TestCases/ImplicitConversion/signed-integer-truncation-or-sign-change-ignorelist.c (4835 of 4880)
PASS: UBSan-ThreadSanitizer-powerpc64le :: TestCases/Pointer/nullptr-and-nonzero-offset-variable.cpp (4836 of 4880)
PASS: UBSan-Standalone-powerpc64le :: TestCases/TypeCheck/vptr.cpp (4837 of 4880)
PASS: ThreadSanitizer-powerpc64le :: deep_stack1.cpp (4838 of 4880)
PASS: UBSan-ThreadSanitizer-powerpc64le :: TestCases/Integer/shift.cpp (4839 of 4880)
PASS: UBSan-AddressSanitizer-powerpc64le :: TestCases/TypeCheck/vptr.cpp (4840 of 4880)
PASS: UBSan-MemorySanitizer-powerpc64le :: TestCases/TypeCheck/vptr.cpp (4841 of 4880)
PASS: UBSan-Standalone-powerpc64le :: TestCases/ImplicitConversion/bitfield-conversion.c (4842 of 4880)
PASS: ScudoStandalone-Unit :: ./ScudoUnitTest-powerpc64le-Test/232/278 (4843 of 4880)
PASS: UBSan-ThreadSanitizer-powerpc64le :: TestCases/ImplicitConversion/signed-integer-truncation-ignorelist.c (4844 of 4880)
PASS: UBSan-AddressSanitizer-powerpc64le :: TestCases/ImplicitConversion/bitfield-conversion.c (4845 of 4880)
PASS: UBSan-ThreadSanitizer-powerpc64le :: TestCases/ImplicitConversion/unsigned-integer-truncation-ignorelist.c (4846 of 4880)
PASS: UBSan-MemorySanitizer-powerpc64le :: TestCases/ImplicitConversion/bitfield-conversion.c (4847 of 4880)
PASS: UBSan-ThreadSanitizer-powerpc64le :: TestCases/TypeCheck/vptr.cpp (4848 of 4880)
PASS: Profile-powerpc64le :: Posix/instrprof-value-prof-shared.test (4849 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-inline-Dynamic-Test/67/96 (4850 of 4880)
PASS: ThreadSanitizer-powerpc64le :: bench_threads.cpp (4851 of 4880)
PASS: UBSan-ThreadSanitizer-powerpc64le :: TestCases/ImplicitConversion/bitfield-conversion.c (4852 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-inline-Dynamic-Test/66/96 (4853 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-calls-Test/67/96 (4854 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-calls-Test/66/96 (4855 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-inline-Test/67/96 (4856 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-calls-Dynamic-Test/66/96 (4857 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-calls-Dynamic-Test/67/96 (4858 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-inline-Test/66/96 (4859 of 4880)
PASS: ScudoStandalone-Unit :: ./ScudoUnitTest-powerpc64le-Test/233/278 (4860 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-inline-Dynamic-Test/32/96 (4861 of 4880)
PASS: ThreadSanitizer-powerpc64le :: deadlock_detector_stress_test.cpp (4862 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-inline-Test/32/96 (4863 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-calls-Dynamic-Test/32/96 (4864 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-calls-Test/32/96 (4865 of 4880)
PASS: ThreadSanitizer-powerpc64le :: restore_stack.cpp (4866 of 4880)
PASS: SanitizerCommon-lsan-powerpc64le-Linux :: Linux/signal_segv_handler.cpp (4867 of 4880)
PASS: SanitizerCommon-asan-powerpc64le-Linux :: Linux/signal_segv_handler.cpp (4868 of 4880)
PASS: SanitizerCommon-ubsan-powerpc64le-Linux :: Linux/signal_segv_handler.cpp (4869 of 4880)
PASS: SanitizerCommon-tsan-powerpc64le-Linux :: Linux/signal_segv_handler.cpp (4870 of 4880)
PASS: SanitizerCommon-msan-powerpc64le-Linux :: Linux/signal_segv_handler.cpp (4871 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-inline-Dynamic-Test/40/96 (4872 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-inline-Test/40/96 (4873 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-calls-Dynamic-Test/40/96 (4874 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-calls-Test/40/96 (4875 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-calls-Test/68/96 (4876 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-inline-Dynamic-Test/68/96 (4877 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-inline-Test/68/96 (4878 of 4880)
PASS: AddressSanitizer-Unit :: ./Asan-powerpc64le-calls-Dynamic-Test/68/96 (4879 of 4880)

command timed out: 1800 seconds without output running [b'python', b'../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=3433.308728

@mtrofin
Copy link
Member

mtrofin commented Mar 20, 2025

When using LLVM_ENABLE_RUNTIMES=compiler-rt instead of LLVM_ENABLE_PROJECTS, the produced compile_commands.json doesn't cover compiler-rt sources. How's this supposed to work with clangd (IDEs, autocompletion...)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitalybuka vitalybuka vitalybuka approved these changes

@nickdesaulniers nickdesaulniers Awaiting requested review from nickdesaulniers

Assignees
No one assigned
Labels
compiler-rt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petrhosek @nickdesaulniers @llvm-ci @mtrofin @vitalybuka