[llvm][Object] Add missing const qualifier for value_type in content_iterator #124106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iterator. value_type was defined as non-const for content_iterator, although it's methods returned a const pointers/references. This prevented it from using in some algorithms from STLExtras.h
|
@llvm/pr-subscribers-llvm-binary-utilities Author: Bushev Dmitry (dybv-sc) Changesvalue_type was defined as non-const for content_iterator, although it's methods returned a const pointers/references. This prevented it from using in some algorithms from STLExtras.h Full diff: https://github.com/llvm/llvm-project/pull/124106.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Object/SymbolicFile.h b/llvm/include/llvm/Object/SymbolicFile.h
index b13588c147d9b2..2c857e72c3e5a6 100644
--- a/llvm/include/llvm/Object/SymbolicFile.h
+++ b/llvm/include/llvm/Object/SymbolicFile.h
@@ -71,7 +71,7 @@ template <class content_type> class content_iterator {
public:
using iterator_category = std::forward_iterator_tag;
- using value_type = content_type;
+ using value_type = const content_type;
using difference_type = std::ptrdiff_t;
using pointer = value_type *;
using reference = value_type &;
|
@kuhar, sure, added unit test |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
dybv-sc
force-pushed
the
object-iterator-const-missing-fix
branch
from
790e62b to
27d2197
Compare
kuhar
reviewed
Jan 24, 2025
jh7370
reviewed
Jan 27, 2025
| #include "llvm/Support/raw_ostream.h" | ||
| #include "llvm/TargetParser/Host.h" | ||
|
|
There was a problem hiding this comment.
Please remove this blank line. Headers should be included as one contiguous block, otherwise clang-format won't sort them properly.
|
@dybv-sc I think this PR have collected enough feedback, let's resolve review comments, thanks! |
kuhar
approved these changes
Jan 27, 2025
jh7370
reviewed
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
value_type was defined as non-const for content_iterator, although it's methods returned a const pointers/references. This prevented it from using in some algorithms from STLExtras.h