Skip to content

[flang] Fix spurious error in character sequence association #124204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025
Merged

[flang] Fix spurious error in character sequence association #124204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions flang/lib/Semantics/check-call.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,9 @@ static void CheckCharacterActual(evaluate::Expr<evaluate::SomeType> &actual,
context.foldingContext(), /*getLastComponent=*/true};
if (auto actualOffset{folder.FoldDesignator(actual)}) {
std::int64_t actualChars{*actualLength};
if (static_cast<std::size_t>(actualOffset->offset()) >=
if (IsAllocatableOrPointer(actualOffset->symbol())) {
// don't use actualOffset->symbol().size()!
} else if (static_cast<std::size_t>(actualOffset->offset()) >=
actualOffset->symbol().size() ||
!evaluate::IsContiguous(
actualOffset->symbol(), foldingContext)) {
Expand Down Expand Up @@ -634,7 +636,9 @@ static void CheckExplicitDataArg(const characteristics::DummyDataObject &dummy,
context.foldingContext(), /*getLastComponent=*/true};
if (auto actualOffset{folder.FoldDesignator(actual)}) {
std::optional<std::int64_t> actualElements;
if (static_cast<std::size_t>(actualOffset->offset()) >=
if (IsAllocatableOrPointer(actualOffset->symbol())) {
// don't use actualOffset->symbol().size()!
} else if (static_cast<std::size_t>(actualOffset->offset()) >=
actualOffset->symbol().size() ||
!evaluate::IsContiguous(
actualOffset->symbol(), foldingContext)) {
Expand Down
36 changes: 36 additions & 0 deletions flang/test/Semantics/call38.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,3 +544,39 @@ subroutine sub2(arg2)
character(*) :: arg2(10)
end subroutine sub2
end subroutine

subroutine bug123807
interface
subroutine test(s)
character(5), intent(inout) :: s(5)
end
end interface
character(30) :: s30a
character(30), allocatable :: s30b
character(6) :: s30c(5)
character(24) :: s24a
character(24), allocatable :: s24b
character(4) :: s24c(6)
allocate(s30b)
allocate(s24b)
call test(s30a)
call test(s30a(6:))
!ERROR: Actual argument has fewer characters remaining in storage sequence (24) than dummy argument 's=' (25)
call test(s30a(7:))
call test(s30b)
call test(s30b(6:))
!ERROR: Actual argument has fewer characters remaining in storage sequence (24) than dummy argument 's=' (25)
call test(s30b(7:))
call test(s30c)
call test(s30c(1)(6:))
!ERROR: Actual argument has fewer characters remaining in storage sequence (24) than dummy argument 's=' (25)
call test(s30c(2))
!ERROR: Actual argument has fewer characters remaining in storage sequence (24) than dummy argument 's=' (25)
call test(s30c(2)(1:))
!ERROR: Actual argument has fewer characters remaining in storage sequence (24) than dummy argument 's=' (25)
call test(s24a)
!ERROR: Actual argument has fewer characters remaining in storage sequence (24) than dummy argument 's=' (25)
call test(s24b)
!ERROR: Actual argument array has fewer characters (24) than dummy argument 's=' array (25)
call test(s24c)
end
Loading