[lldb] Remove unused posix_openpt function definition for Android #124257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was for the wrapper function that was in source/Host/android/LibcGlue.cpp. Android added support 10+ years ago.
|
@llvm/pr-subscribers-lldb Author: Brad Smith (brad0) ChangesThis was for the wrapper function that was in Full diff: https://github.com/llvm/llvm-project/pull/124257.diff 1 Files Affected:
diff --git a/lldb/source/Host/common/PseudoTerminal.cpp b/lldb/source/Host/common/PseudoTerminal.cpp
index d53327973eb270..53e91aff212a4a 100644
--- a/lldb/source/Host/common/PseudoTerminal.cpp
+++ b/lldb/source/Host/common/PseudoTerminal.cpp
@@ -27,10 +27,6 @@
#include <Availability.h>
#endif
-#if defined(__ANDROID__)
-int posix_openpt(int flags);
-#endif
-
using namespace lldb_private;
// PseudoTerminal constructor
|
labath
approved these changes
Jan 24, 2025
enh-google
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was for the wrapper function that was in
source/Host/android/LibcGlue.cpp. Android added
support 10+ years ago.