[OpenACC] add AutomaticAllocationScope to recipe ops

[rscottmanley]

The recipe operators should have AutomaticAllocationScope so recipes can be converted using operators that require parent ops to have AutomaticAllocationScope

[llvmbot]

@llvm/pr-subscribers-mlir
@llvm/pr-subscribers-openacc

@llvm/pr-subscribers-mlir-openacc

Author: Scott Manley (rscottmanley)

Changes

The recipe operators should have AutomaticAllocationScope so recipes can be converted using operators that require parent ops to have AutomaticAllocationScope

---

Full diff: https://github.com/llvm/llvm-project/pull/124337.diff

1 Files Affected:

• (modified) mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td (+11-6)

diff --git a/mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td b/mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td
index c60eb5cc620a7d..7e9ed2c741cf76 100644
--- a/mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td
+++ b/mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td
@@ -1008,8 +1008,9 @@ def OpenACC_UpdateHostOp : OpenACC_DataExitOpWithVarPtr<"update_host",
 // 2.5.13 private clause
 //===----------------------------------------------------------------------===//
 
-def OpenACC_PrivateRecipeOp : OpenACC_Op<"private.recipe",
-    [IsolatedFromAbove, Symbol, RecipeInterface]> {
+def OpenACC_PrivateRecipeOp
+    : OpenACC_Op<"private.recipe", [IsolatedFromAbove, Symbol, RecipeInterface,
+                                    AutomaticAllocationScope]> {
   let summary = "privatization recipe";
 
   let description = [{
@@ -1065,8 +1066,10 @@ def OpenACC_PrivateRecipeOp : OpenACC_Op<"private.recipe",
 // 2.5.14 firstprivate clause
 //===----------------------------------------------------------------------===//
 
-def OpenACC_FirstprivateRecipeOp : OpenACC_Op<"firstprivate.recipe",
-    [IsolatedFromAbove, Symbol, RecipeInterface]> {
+def OpenACC_FirstprivateRecipeOp
+    : OpenACC_Op<"firstprivate.recipe", [IsolatedFromAbove, Symbol,
+                                         RecipeInterface,
+                                         AutomaticAllocationScope]> {
   let summary = "privatization recipe";
 
   let description = [{
@@ -1131,8 +1134,10 @@ def OpenACC_FirstprivateRecipeOp : OpenACC_Op<"firstprivate.recipe",
 // 2.5.15 reduction clause
 //===----------------------------------------------------------------------===//
 
-def OpenACC_ReductionRecipeOp : OpenACC_Op<"reduction.recipe",
-    [IsolatedFromAbove, Symbol, RecipeInterface]> {
+def OpenACC_ReductionRecipeOp
+    : OpenACC_Op<"reduction.recipe", [IsolatedFromAbove, Symbol,
+                                      RecipeInterface,
+                                      AutomaticAllocationScope]> {
   let summary = "reduction recipe";
 
   let description = [{

[razvanlupusoru]

Can you please add a test to mlir/test/Dialect/OpenACC/ops.mlir ?
We already have a recipe test which uses memref.alloc - can you please make one that uses memref.alloca? (which does require the allocation scope)

[rscottmanley]

Can you please add a test to mlir/test/Dialect/OpenACC/ops.mlir ? We already have a recipe test which uses memref.alloc - can you please make one that uses memref.alloca? (which does require the allocation scope)

added, thanks for the review!

[clementval]

LGTM

[razvanlupusoru]

Thank you!