[offload] [test] Use test compiler ID rather than host #124408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the test compiler ID to verify whether tests can be run rather than the host compiler. This makes it possible to run tests (with Clang) while the library itself was built with GCC.
|
@llvm/pr-subscribers-offload Author: Michał Górny (mgorny) ChangesUse the test compiler ID to verify whether tests can be run rather than the host compiler. This makes it possible to run tests (with Clang) while the library itself was built with GCC. Full diff: https://github.com/llvm/llvm-project/pull/124408.diff 1 Files Affected:
diff --git a/offload/test/CMakeLists.txt b/offload/test/CMakeLists.txt
index 8a827e0a625eff..4768d9ccf223bb 100644
--- a/offload/test/CMakeLists.txt
+++ b/offload/test/CMakeLists.txt
@@ -1,6 +1,6 @@
# CMakeLists.txt file for unit testing OpenMP offloading runtime library.
-if(NOT CMAKE_CXX_COMPILER_ID STREQUAL "Clang" OR
- CMAKE_CXX_COMPILER_VERSION VERSION_LESS 6.0.0)
+if(NOT OPENMP_TEST_COMPILER_ID STREQUAL "Clang" OR
+ OPENMP_TEST_COMPILER_VERSION VERSION_LESS 6.0.0)
message(STATUS "Can only test with Clang compiler in version 6.0.0 or later.")
message(WARNING "The check-offload target will not be available!")
return()
|
jhuber6
approved these changes
Jan 25, 2025
| if(NOT CMAKE_CXX_COMPILER_ID STREQUAL "Clang" OR | ||
| CMAKE_CXX_COMPILER_VERSION VERSION_LESS 6.0.0) | ||
| if(NOT OPENMP_TEST_COMPILER_ID STREQUAL "Clang" OR | ||
| OPENMP_TEST_COMPILER_VERSION VERSION_LESS 6.0.0) |
There was a problem hiding this comment.
I wonder if we really need this check anymore.
There was a problem hiding this comment.
Yeah, I was kinda surprised to see it. It's kinda true you usually can't test runtimes without Clang, but not sure if runtimes really need to explicitly assert that.
thesamesam
approved these changes
Jan 25, 2025
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Feb 5, 2025
Use the test compiler ID to verify whether tests can be run rather than the host compiler. This makes it possible to run tests (with Clang) while the library itself was built with GCC. (cherry picked from commit 689ef5f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the test compiler ID to verify whether tests can be run rather than the host compiler. This makes it possible to run tests (with Clang) while the library itself was built with GCC.