Skip to content

[Clang] Skip past code generation for unevaluated lambdas #124572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clang/docs/ReleaseNotes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -966,6 +966,7 @@ Bug Fixes to C++ Support
constraints are applied. (#GH122134)
- Fixed canonicalization of pack indexing types - Clang did not always recognized identical pack indexing. (#GH123033)
- Fixed a nested lambda substitution issue for constraint evaluation. (#GH123441)
- Fixed some crashes involving unevaluated lambdas during code generation. (#GH82926)


Bug Fixes to AST Handling
Expand Down
20 changes: 18 additions & 2 deletions clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5297,8 +5297,24 @@ void Sema::InstantiateFunctionDefinition(SourceLocation PointOfInstantiation,
savedContext.pop();
}

DeclGroupRef DG(Function);
Consumer.HandleTopLevelDecl(DG);
// We never need to emit the code for a lambda in unevaluated context.
// We also can't mangle a lambda in the require clause of a function template
// during constraint checking as the MSI ABI would need to mangle the (not yet
// specialized) enclosing declaration
// FIXME: Should we try to skip this for non-lambda functions too?
bool ShouldSkipCG = [&] {
auto *RD = dyn_cast<CXXRecordDecl>(Function->getParent());
if (!RD || !RD->isLambda())
return false;

return llvm::any_of(ExprEvalContexts, [](auto &Context) {
return Context.isUnevaluated() || Context.isImmediateFunctionContext();
});
}();
if (!ShouldSkipCG) {
DeclGroupRef DG(Function);
Consumer.HandleTopLevelDecl(DG);
}

// This class may have local implicit instantiations that need to be
// instantiation within this scope.
Expand Down
37 changes: 37 additions & 0 deletions clang/test/CodeGenCXX/unevaluated-lambdas.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
// RUN: %clang_cc1 -std=c++2b -emit-llvm %s -o - | FileCheck %s -dump-input=always

namespace GH82926 {

template<class Tp>
using simd_vector = Tp;

template<class VecT>
using simd_vector_underlying_type_t
= decltype([]<class Tp>(simd_vector<Tp>) {}(VecT {}), 1);

template<class VecT>
void temp() {
// CHECK: call void @_ZZN7GH829264tempIcEEvvENKUliE_clEi
[](simd_vector_underlying_type_t<VecT>) {}(42);
}

void call() {
temp<simd_vector<char>>();
}

} // namespace GH82926

namespace GH111058 {

// FIXME: This still crashes because the unevaluated lambda as an argument
// is also supposed to skipping codegen in Sema::InstantiateFunctionDefinition().
// auto eat(auto) {}

void foo() {
// [] -> decltype(eat([] {})) {};

// CHECK: call void @"_ZZN8GH1110583fooEvENK3$_0clEv"
[] -> decltype([](auto){}(1)) {}();
}

} // namespace GH111058
Loading