[NFC] Remove redundant sys/file.h header.
#124684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-llvm-support Author: None (c8ef) ChangesCloses #124652. Full diff: https://github.com/llvm/llvm-project/pull/124684.diff 1 Files Affected:
diff --git a/llvm/lib/Support/Unix/Path.inc b/llvm/lib/Support/Unix/Path.inc
index 1ad3a549a5a542..6004e007c0c7a0 100644
--- a/llvm/lib/Support/Unix/Path.inc
+++ b/llvm/lib/Support/Unix/Path.inc
@@ -29,7 +29,6 @@
#include <dirent.h>
#include <pwd.h>
-#include <sys/file.h>
#ifdef __APPLE__
#include <copyfile.h>
|
nickdesaulniers
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Let's try this, but if merging it breaks the build, let's revert? Consider mentioning 5367369 in the commit message when you merge this, and that it should have just relied on the already included fcntl.h. Thanks for the patch!
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124652.
This header was introduced in 5367369, but it appears that including only
fnctl.hshould be enough. Hopefully, this patch will not cause build issues on other Unix platforms.