Skip to content

[libc++] Remove Android header no longer in use #124691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

brad0
Copy link
Contributor

@brad0 brad0 commented Jan 28, 2025

929f159 removed the use of __ANDROID_API__

929f159 removed the use of __ANDROID_API__
@brad0 brad0 requested a review from a team as a code owner January 28, 2025 04:11
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jan 28, 2025
@llvmbot
Copy link
Member

llvmbot commented Jan 28, 2025

@llvm/pr-subscribers-libcxx

Author: Brad Smith (brad0)

Changes

929f159 removed the use of ANDROID_API


Full diff: https://github.com/llvm/llvm-project/pull/124691.diff

1 Files Affected:

  • (modified) libcxx/src/system_error.cpp (-4)
diff --git a/libcxx/src/system_error.cpp b/libcxx/src/system_error.cpp
index d5ec73084f638f..164fb72621c17c 100644
--- a/libcxx/src/system_error.cpp
+++ b/libcxx/src/system_error.cpp
@@ -21,10 +21,6 @@
 
 #include "include/config_elast.h"
 
-#if defined(__ANDROID__)
-#  include <android/api-level.h>
-#endif
-
 #if defined(_LIBCPP_WIN32API)
 #  include <windows.h>
 #  include <winerror.h>

@brad0 brad0 requested a review from enh-google January 28, 2025 04:14
Copy link
Contributor

@philnik777 philnik777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philnik777 philnik777 merged commit 9c92824 into llvm:main Jan 28, 2025
80 checks passed
@brad0 brad0 deleted the libcxx_android branch January 28, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants