Skip to content

[CodeGen][NewPM] Preserve all MF analyses in MFPM #124707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

optimisan
Copy link
Contributor

@optimisan optimisan commented Jan 28, 2025

Invalidation is already handled in the passes loop for MFAM, so all of the rest analyses are preserved. (See PassManager::run)

This won't change the number of invalidations, but will prevent needless MFAM::Invalidator::invalidate() invocations made by results depending on other results (since the invalidate shorts if <AllAnalysesOn<MF>> is preserved)

@optimisan optimisan changed the title [CodeGen][NewPM] Preserve MF analyses in MFPM [CodeGen][NewPM] Preserve all MF analyses in MFPM Jan 28, 2025
@optimisan optimisan merged commit 11026a8 into llvm:main Jan 30, 2025
7 of 9 checks passed
@optimisan optimisan deleted the preserve-mf-analysis-pm branch January 30, 2025 04:32
@llvm-ci
Copy link
Collaborator

llvm-ci commented Jan 30, 2025

LLVM Buildbot has detected a new failure on builder lldb-aarch64-windows running on linaro-armv8-windows-msvc-05 while building llvm at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/5853

Here is the relevant piece of the build log for the reference
Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: commands/platform/file/close/TestPlatformFileClose.py (177 of 2066)
PASS: lldb-api :: commands/platform/file/read/TestPlatformFileRead.py (178 of 2066)
XFAIL: lldb-api :: commands/platform/connect/TestPlatformConnect.py (179 of 2066)
UNSUPPORTED: lldb-api :: commands/platform/launchgdbserver/TestPlatformLaunchGDBServer.py (180 of 2066)
UNSUPPORTED: lldb-api :: commands/platform/process/list/TestProcessList.py (181 of 2066)
UNSUPPORTED: lldb-api :: commands/platform/sdk/TestPlatformSDK.py (182 of 2066)
UNSUPPORTED: lldb-api :: commands/process/attach-resume/TestAttachResume.py (183 of 2066)
PASS: lldb-api :: commands/platform/process/launch/TestPlatformProcessLaunch.py (184 of 2066)
UNSUPPORTED: lldb-api :: commands/process/attach/attach_denied/TestAttachDenied.py (185 of 2066)
PASS: lldb-api :: commands/process/continue_to_bkpt/TestContinueToBkpts.py (186 of 2066)
FAIL: lldb-api :: commands/process/detach-resumes/TestDetachResumes.py (187 of 2066)
******************** TEST 'lldb-api :: commands/process/detach-resumes/TestDetachResumes.py' FAILED ********************
Script:
--
C:/Users/tcwg/scoop/apps/python/current/python.exe C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/llvm-project/lldb\test\API\dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./lib --env LLVM_INCLUDE_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/include --env LLVM_TOOLS_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin --arch aarch64 --build-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex --lldb-module-cache-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-lldb\lldb-api --clang-module-cache-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-clang\lldb-api --executable C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/lldb.exe --compiler C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/clang.exe --dsymutil C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/dsymutil.exe --make C:/Users/tcwg/scoop/shims/make.exe --llvm-tools-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin --lldb-obj-root C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/tools/lldb --lldb-libs-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./lib --skip-category=watchpoint C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\commands\process\detach-resumes -p TestDetachResumes.py
--
Exit Code: 1

Command Output (stdout):
--
lldb version 21.0.0git (https://github.com/llvm/llvm-project.git revision 11026a8d8b03014665e18c5cf9a0f76c857ef85f)
  clang revision 11026a8d8b03014665e18c5cf9a0f76c857ef85f
  llvm revision 11026a8d8b03014665e18c5cf9a0f76c857ef85f
Skipping the following test categories: ['watchpoint', 'libc++', 'libstdcxx', 'dwo', 'dsym', 'gmodules', 'debugserver', 'objc', 'fork', 'pexpect']


--
Command Output (stderr):
--
ls: cannot access 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\lldb-test-build.noindex\commands\process\detach-resumes\TestDetachResumes.test_detach_resumes\exit_file_1738213828': No such file or directory
ls: cannot access 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\lldb-test-build.noindex\commands\process\detach-resumes\TestDetachResumes.test_detach_resumes\exit_file_1738213828': No such file or directory
ls: cannot access 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\lldb-test-build.noindex\commands\process\detach-resumes\TestDetachResumes.test_detach_resumes\exit_file_1738213828': No such file or directory
ls: cannot access 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\lldb-test-build.noindex\commands\process\detach-resumes\TestDetachResumes.test_detach_resumes\exit_file_1738213828': No such file or directory
ls: cannot access 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\lldb-test-build.noindex\commands\process\detach-resumes\TestDetachResumes.test_detach_resumes\exit_file_1738213828': No such file or directory
ls: cannot access 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\lldb-test-build.noindex\commands\process\detach-resumes\TestDetachResumes.test_detach_resumes\exit_file_1738213828': No such file or directory
FAIL: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_detach_resumes (TestDetachResumes.DetachResumesTestCase.test_detach_resumes)

======================================================================

FAIL: test_detach_resumes (TestDetachResumes.DetachResumesTestCase.test_detach_resumes)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\commands\process\detach-resumes\TestDetachResumes.py", line 59, in test_detach_resumes

    lldbutil.wait_for_file_on_target(self, exit_file_path)


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants